feat(alloydb): add write-only password support to google_alloydb_user wt write_only_legacy#15661
Conversation
This change adds write-only password support to the google_alloydb_user resource, enabling users to manage passwords without storing them in Terraform state. Changes: - Added write_only: true to password field in User.yaml - Added test cases for password_wo and password_wo_version fields - Automatically generates password_wo and password_wo_version fields via MMv1 This enables secure password management with Secret Manager and ephemeral values.
write_only_legacy
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. |
Tests analyticsTotal tests: 88 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 1 week. Please take a look! Use the label |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 88 Click here to see the affected service packages
🟢 All tests passed! View the build log |
| @@ -0,0 +1,17 @@ | |||
| {{/* | |||
There was a problem hiding this comment.
- write-only fields (password/password_wo) are not in CAI data so standard code generation fails
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 88 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
Release Note Template for Downstream PRs (will be copied)
hashicorp/terraform-provider-google#25089