Adding Terraform support for ExadVmCluster Resource

[siddhisingh-13]

Fixed hashicorp/terraform-provider-google#24873

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_oracle_database_exadb_vm_cluster`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[melinath]

Please fix the failing tests and also add an update test if possible! https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-update-test

[github-actions]

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[melinath]

did a quick scan and don't see anything obviously off, but we need to get the tests passing before this can be merged.

[melinath]

It's now possible to specify additional sweepable prefixes for resources - we should clean this up. https://googlecloudplatform.github.io/magic-modules/reference/resource/#sweeper-1

[melinath]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2185 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2185 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 501 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 298 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_exadb_vm_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_exadb_vm_cluster" "primary" {
  properties {
    time_zone {
      version = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 26
Passed tests: 24
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterBasicExample
• TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterBasicExample [Error message] [Debug log]
TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

Error code 13 is gone! 🎉

Things to fix:

• Sweeper customization previously mentioned
• Exercise properties.time_zone.version in a test
• Data collection options isn't being returned by the API, which is causing the test failure. https://googlecloudplatform.github.io/magic-modules/develop/diffs/ has details on how to resolve this kind of failure. Let me know if you run into any questions!
• Please add an update test to exercise update-in-place: https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-update-test

[github-actions]

@siddhisingh-13, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@siddhisingh-13, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2188 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2188 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 501 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 298 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_exadb_vm_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_exadb_vm_cluster" "primary" {
  properties {
    time_zone {
      version = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 26
Passed tests: 24
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterBasicExample
• TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterBasicExample [Error message] [Debug log]
TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2185 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2185 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 501 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 298 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_exadb_vm_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_exadb_vm_cluster" "primary" {
  properties {
    time_zone {
      version = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 26
Passed tests: 24
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterBasicExample
• TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterBasicExample [Error message] [Debug log]
TestAccOracleDatabaseExadbVmCluster_oracledatabaseExadbVmClusterFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.