Add Dialogflow Environment Resource

[Spheny1]

Add support for Dialogflow Environment.
Release Note Template for Downstream PRs (will be copied)

`google_dialogflow_environment`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 454 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_environment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_environment" "primary" {
  fulfillment {
    display_name = # value needed
    features {
      type = # value needed
    }
    generic_web_service {
      password        = # value needed
      request_headers = # value needed
      uri             = # value needed
      username        = # value needed
    }
    name = # value needed
  }
  location = # value needed
  text_to_speech_settings {
    output_audio_encoding = # value needed
    synthesize_speech_configs {
      volume_gain_db = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_dialogflow_environment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 16
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• dialogflow

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample
• TestAccDialogflowEnvironment_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDialogflowEnvironment_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[NickElliot]

test is failing due to this unclosed string

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 454 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_environment (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_environment" "primary" {
  fulfillment {
    display_name = # value needed
    features {
      type = # value needed
    }
    generic_web_service {
      password        = # value needed
      request_headers = # value needed
      uri             = # value needed
      username        = # value needed
    }
    name = # value needed
  }
  location = # value needed
  text_to_speech_settings {
    output_audio_encoding = # value needed
    synthesize_speech_configs {
      volume_gain_db = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_dialogflow_environment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[Spheny1]

What is the new error that this throwing clicking on the link gives me a 403 error and I have this working locally so I am not sure what I need to do.

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 454 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_environment (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_environment" "primary" {
  fulfillment {
    display_name = # value needed
    features {
      type = # value needed
    }
    generic_web_service {
      password        = # value needed
      request_headers = # value needed
      uri             = # value needed
      username        = # value needed
    }
    name = # value needed
  }
  location = # value needed
  text_to_speech_settings {
    output_audio_encoding = # value needed
    synthesize_speech_configs {
      volume_gain_db = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_dialogflow_environment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

you still have unclosed strings in these!

resource_dialogflow_environment_generated_test.go:62: Step 1/2 error: Error running pre-apply refresh: exit status 1

    Error: Invalid multi-line string
    
      on terraform_plugin_test.tf line 39, in resource "google_dialogflow_environment" "basic_environment":
      39:   description = "basic environment
      40:   depends_on = [google_dialogflow_agent.basic_agent]
    
    Quoted strings may not be split over multiple lines. To produce a multi-line
    string, either use the \n escape to represent a newline character or use the
    "heredoc" multi-line template syntax.

[NickElliot]

here

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

remove these please! this attribute is deprecated

[NickElliot]

I'm not sure why this build is failing at this point given it was fine before
The experienced error is as follows:

Property synthesizeSpeechConfigs value_type.name can't be set in resource Environment

is this still building successfully for you locally?

[zli82016]

I'm not sure why this build is failing at this point given it was fine before The experienced error is as follows:

Property synthesizeSpeechConfigs value_type.name can't be set in resource Environment

is this still building successfully for you locally?

A new validation is added in the #16179.

That could be the reason.

[NickElliot]

thanks for the pointer zhenhua!
please remove this line

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1813 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1813 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 454 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_environment (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_environment" "primary" {
  fulfillment {
    display_name = # value needed
    features {
      type = # value needed
    }
    generic_web_service {
      password        = # value needed
      request_headers = # value needed
      uri             = # value needed
      username        = # value needed
    }
    name = # value needed
  }
  location = # value needed
  text_to_speech_settings {
    output_audio_encoding = # value needed
    synthesize_speech_configs {
      volume_gain_db = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_dialogflow_environment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[NickElliot]

Test is now hitting the error:

Error: Error creating Environment: googleapi: Error 404: com.google.apps.framework.request.NotFoundException: No intent-based agent found for project id 'ci-test-project-188019'.
with google_dialogflow_environment.basic_environment,

Add a
depends_on = [google_dialogflow_agent.agent]
to the environment resource in the test!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1815 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1815 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 454 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_environment (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_environment" "primary" {
  fulfillment {
    display_name = # value needed
    features {
      type = # value needed
    }
    generic_web_service {
      password        = # value needed
      request_headers = # value needed
      uri             = # value needed
      username        = # value needed
    }
    name = # value needed
  }
  location = # value needed
  text_to_speech_settings {
    output_audio_encoding = # value needed
    synthesize_speech_configs {
      volume_gain_db = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_dialogflow_environment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test