Creating dev environment to be used by product #16022

rickygodoy · 2025-12-23T17:02:03Z

Bug fix for failing tests:

The Product API didn't validate the environment parameter before, which caused invalid ones to break the test. Now, a dev environment is always present and valid to be used in the product.

github-actions · 2025-12-23T17:03:00Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

BBBmau · 2025-12-23T17:08:54Z

mmv1/templates/terraform/examples/apigee_api_product_with_attributes_test.tf.tmpl

  quota_time_unit     = "day"
  quota_counter_scope = "PROXY"

-  environments = ["dev", "hom"]


why was "hom" removed from the list? Is this an environment that just isn't present in our testing project?

Because it's not needed. The environments field wasn't being validated on API side, now I cut down the example only to dev to make it easier to test/understand.

modular-magician · 2025-12-23T17:12:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 45 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 45 insertions(+), 11 deletions(-))

modular-magician · 2025-12-23T17:24:44Z

Tests analytics

Total tests: 72
Passed tests: 32
Skipped tests: 37
Affected tests: 3

Click here to see the affected service packages

apigee

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample

TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample

TestAccApigeeApiProduct_apigeeApiProduct_full

Get to know how VCR tests work

modular-magician · 2025-12-23T17:49:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 59 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 59 insertions(+), 11 deletions(-))

modular-magician · 2025-12-23T18:01:08Z

Tests analytics

Total tests: 72
Passed tests: 32
Skipped tests: 37
Affected tests: 3

Click here to see the affected service packages

apigee

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample

TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample

TestAccApigeeApiProduct_apigeeApiProduct_full

Get to know how VCR tests work

modular-magician · 2025-12-23T18:11:47Z

🔴 Tests failed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProduct_full [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-12-23T18:12:57Z

🔴 Tests failed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProduct_full [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

shuyama1 · 2025-12-23T18:23:42Z

/gcbrun

modular-magician · 2025-12-23T18:34:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 59 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 59 insertions(+), 11 deletions(-))

modular-magician · 2025-12-23T18:45:47Z

Tests analytics

Total tests: 72
Passed tests: 32
Skipped tests: 37
Affected tests: 3

Click here to see the affected service packages

apigee

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample

TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample

TestAccApigeeApiProduct_apigeeApiProduct_full

Get to know how VCR tests work

modular-magician · 2025-12-23T19:39:17Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample [Debug log]
TestAccApigeeApiProduct_apigeeApiProduct_full [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-12-23T19:52:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 59 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 3 files changed, 59 insertions(+), 11 deletions(-))

modular-magician · 2025-12-23T20:04:08Z

Tests analytics

Total tests: 72
Passed tests: 34
Skipped tests: 37
Affected tests: 1

Click here to see the affected service packages

apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample

Get to know how VCR tests work

modular-magician · 2025-12-23T20:19:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 65 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 3 files changed, 65 insertions(+), 12 deletions(-))

modular-magician · 2025-12-23T20:31:01Z

Tests analytics

Total tests: 72
Passed tests: 33
Skipped tests: 37
Affected tests: 2

Click here to see the affected service packages

apigee

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample

TestAccApigeeApiProduct_apigeeApiProduct_full

Get to know how VCR tests work

modular-magician · 2025-12-23T20:50:43Z

🔴 Tests failed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-12-23T21:07:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 65 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 3 files changed, 65 insertions(+), 12 deletions(-))

modular-magician · 2025-12-23T21:19:35Z

Tests analytics

Total tests: 72
Passed tests: 33
Skipped tests: 37
Affected tests: 2

Click here to see the affected service packages

apigee

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample

TestAccApigeeApiProduct_apigeeApiProduct_full

Get to know how VCR tests work

modular-magician · 2025-12-23T21:24:40Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProduct_full [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

rickygodoy · 2025-12-23T21:32:52Z

/gcbrun

modular-magician · 2025-12-23T21:48:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 65 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 3 files changed, 65 insertions(+), 12 deletions(-))

modular-magician · 2025-12-23T22:00:05Z

Tests analytics

Total tests: 72
Passed tests: 34
Skipped tests: 37
Affected tests: 1

Click here to see the affected service packages

apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample

Get to know how VCR tests work

modular-magician · 2025-12-23T22:11:03Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Debug log]
TestAccApigeeApiProduct_apigeeApiProduct_full [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

shuyama1 · 2025-12-23T22:19:23Z

@modular-magician reassign-reviewer @shuyama1

modular-magician · 2025-12-23T22:49:05Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

shuyama1

Thank you!

…6022)

Creating dev environment to be used by product.

5251c79

github-actions bot requested a review from BBBmau December 23, 2025 17:03

BBBmau reviewed Dec 23, 2025

View reviewed changes

modular-magician added the service/apigee label Dec 23, 2025

Fixing missing Proxy on legacy schema.

7b682ae

github-actions bot requested a review from BBBmau December 23, 2025 17:40

Fixing typo on bundle path name.

d1c2e01

Adding multiple envs to update.

4ffa21e

API proxy expects org name without "organizations" prefix.

2201022

Changing from id to name also on template.

ee2753f

github-actions bot requested review from shuyama1 and removed request for BBBmau December 23, 2025 22:20

shuyama1 approved these changes Dec 23, 2025

View reviewed changes

shuyama1 added this pull request to the merge queue Dec 23, 2025

Merged via the queue into GoogleCloudPlatform:main with commit fc825ab Dec 23, 2025
26 checks passed

This was referenced Dec 23, 2025

Creating dev environment to be used by product hashicorp/terraform-provider-google-beta#11328

Merged

Creating dev environment to be used by product hashicorp/terraform-provider-google#25644

Merged

abhijeetkjha-google pushed a commit to abhijeetkjha-google/magic-modules that referenced this pull request Jan 2, 2026

Creating dev environment to be used by product (GoogleCloudPlatform#1…

2fa165c

…6022)

shang-jason pushed a commit to shang-jason/magic-modules that referenced this pull request Jan 7, 2026

Creating dev environment to be used by product (GoogleCloudPlatform#1…

32d1c61

…6022)

Creating dev environment to be used by product #16022

Creating dev environment to be used by product #16022

Uh oh!

Conversation

rickygodoy commented Dec 23, 2025 • edited by shuyama1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BBBmau Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

rickygodoy Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Dec 23, 2025

Diff report

Uh oh!

modular-magician commented Dec 23, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 23, 2025

Diff report

Uh oh!

modular-magician commented Dec 23, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 23, 2025

Uh oh!

modular-magician commented Dec 23, 2025

Uh oh!

shuyama1 commented Dec 23, 2025

Uh oh!

modular-magician commented Dec 23, 2025

Diff report

Uh oh!

modular-magician commented Dec 23, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 23, 2025

Uh oh!

modular-magician commented Dec 23, 2025

Diff report

Uh oh!

modular-magician commented Dec 23, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 23, 2025

Diff report

Uh oh!

modular-magician commented Dec 23, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 23, 2025

Uh oh!

modular-magician commented Dec 23, 2025

Diff report

Uh oh!

modular-magician commented Dec 23, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 23, 2025

Uh oh!

rickygodoy commented Dec 23, 2025

Uh oh!

modular-magician commented Dec 23, 2025

Diff report

Uh oh!

modular-magician commented Dec 23, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 23, 2025

rickygodoy commented Dec 23, 2025 •

edited by shuyama1

Loading

github-actions bot commented Dec 23, 2025 •

edited

Loading