Support node drain config

[cwangVT]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `node_drain_config` field to `google_container_node_pool` resources

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 139 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 139 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (518 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_drain_config {
      respect_pdb_during_node_pool_deletion = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_container_cluster
  • Expected Document Path: /website/docs/r/container_cluster.html.markdown
  • Fields: [node_pool.node_drain_config node_pool.node_drain_config.respect_pdb_during_node_pool_deletion]

[modular-magician]

Tests analytics

Total tests: 271
Passed tests: 254
Skipped tests: 11
Affected tests: 6

Click here to see the affected service packages

• container

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_networkPerformanceConfig
• TestAccContainerCluster_withTPUConfig
• TestAccContainerCluster_withTpu
• TestAccContainerNodePool_nestedVirtualization
• TestAccContainerNodePool_secondaryBootDisks
• TestAccContainerNodePool_withNodeDrainConfig

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerNodePool_nestedVirtualization [Debug log]
TestAccContainerNodePool_withNodeDrainConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_networkPerformanceConfig [Error message] [Debug log]
TestAccContainerCluster_withTPUConfig [Error message] [Debug log]
TestAccContainerCluster_withTpu [Error message] [Debug log]
TestAccContainerNodePool_secondaryBootDisks [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[malhotrasagar2212]

@cwangVT Could you please check the Missing Test Report. Thanks !
#16087 (comment)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 194 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 194 insertions(+), 1 deletion(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_container_cluster
  • Expected Document Path: /website/docs/r/container_cluster.html.markdown
  • Fields: [node_pool.node_drain_config node_pool.node_drain_config.respect_pdb_during_node_pool_deletion]

[modular-magician]

Tests analytics

Total tests: 274
Passed tests: 258
Skipped tests: 15
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_withNodePoolNodeDrainConfig

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withNodePoolNodeDrainConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[cwangVT]

@cwangVT Could you please check the Missing Test Report. Thanks ! #16087 (comment)

Done for the missing test. And the suggest for Missing doc report does not apply here

[github-actions]

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[malhotrasagar2212]

LGTM, Thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 198 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 6 files changed, 198 insertions(+), 1 deletion(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_container_cluster
  • Expected Document Path: /website/docs/r/container_cluster.html.markdown
  • Fields: [node_pool.node_drain_config node_pool.node_drain_config.respect_pdb_during_node_pool_deletion]

[modular-magician]

Tests analytics

Total tests: 274
Passed tests: 259
Skipped tests: 15
Affected tests: 0

Click here to see the affected service packages

• container

🟢 All tests passed!

View the build log

[cwangVT]

Hey @malhotrasagar2212, the previous merge was blocked due to field is missing in meta.yaml:

I pushed anther commit to add the new field to those yaml files. Please take another look

[malhotrasagar2212]

LGTM, Thanks!