Skip to content

Conversation

@zli82016
Copy link
Member

@zli82016 zli82016 commented Jan 7, 2026

Added the folder sweeper to sweep the folders with the prefix tf-test.
Sometimes deleting folders failed because the folders are not empty.
The PR only cover the case that the folders have configured capability. Other non-empty cases could be handled in the future.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 74 insertions(+))
google-beta provider: Diff ( 1 file changed, 74 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • resourcemanager

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 81 insertions(+))
google-beta provider: Diff ( 1 file changed, 81 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 168
Passed tests: 138
Skipped tests: 30
Affected tests: 0

Click here to see the affected service packages
  • resourcemanager

🟢 All tests passed!

View the build log

@zli82016 zli82016 force-pushed the folder-sweeper branch 2 times, most recently from 19acdd0 to 51a496d Compare January 8, 2026 16:32
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 199 insertions(+))
google-beta provider: Diff ( 1 file changed, 199 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • resourcemanager

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 199 insertions(+))
google-beta provider: Diff ( 1 file changed, 199 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 168
Passed tests: 138
Skipped tests: 30
Affected tests: 0

Click here to see the affected service packages
  • resourcemanager

🟢 All tests passed!

View the build log

@zli82016 zli82016 marked this pull request as ready for review January 8, 2026 18:52
@zli82016 zli82016 requested a review from shuyama1 January 8, 2026 18:53
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. However, should this follow the same logic as the project sweeper? Like, introducing a env var to be able to skip this? mmv1/third_party/terraform/services/resourcemanager/resource_google_project_sweeper.go

We likely need to skip this in service sweeper runs in provider tests and instead run that after all nightly tests are done, alongside the project sweeper for the organization

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 223 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 209 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 167
Passed tests: 137
Skipped tests: 30
Affected tests: 0

Click here to see the affected service packages
  • resourcemanager

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 223 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 209 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 168
Passed tests: 138
Skipped tests: 30
Affected tests: 0

Click here to see the affected service packages
  • resourcemanager

🟢 All tests passed!

View the build log

@zli82016
Copy link
Member Author

zli82016 commented Jan 9, 2026

Looks good overall. However, should this follow the same logic as the project sweeper? Like, introducing a env var to be able to skip this? mmv1/third_party/terraform/services/resourcemanager/resource_google_project_sweeper.go

We likely need to skip this in service sweeper runs in provider tests and instead run that after all nightly tests are done, alongside the project sweeper for the organization

Good catch. Thanks for pointing it out. I added the env var for folder sweeper and env var works locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants