-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Made meta.yaml tests raise parsing errors and enforce accuracy #16102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This also refactors how metadata.yaml caching works to be more streamlines
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
@zli82016 I'm done with this PR for now - let me know if it looks good from the TGC perspective, thanks! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 5901 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the PR locally and the test metadata doesn't change. The logged errors are not parsed in the TGC workflow.
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🟢 All tests passed! |
Tests analyticsTotal tests: 5900 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🟢 All tests passed! |
7b3c803
This PR refactors how the meta.yaml files are processed in tests so that we're able to catch errors in loading the metadata (for example parsing errors like the one fixed by #16100).
I wasn't sure how much of the logged errors are a contract that TGC's later parsing requires; I tried to keep the output as similar as possible.
I removed the "statistic" approach since at this point we need to expect 100% correctness in meta.yaml files.
Note: There are some metadata issues that will need to be fixed before this can be merged. I'll fix them in a follow-on commit, but for now they can serve to demonstrate that the logic works.
Primarily want review from @zli82016 on this as TGC owner, but cc @ScottSuarez if you want to verify that it all looks correct.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.