FEATURE: add ResourceIdentity Support
#16144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 4022 Click here to see the affected service packages
Action takenFound 787 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Member
Author
|
/gcbrun |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Member
Author
|
@BBBmau The total tests number reported in #16144 (comment) is significantly lower than the full test suite. It appears the full test run failed to complete due to multiple provider crashes, according to the build log, and confirmed that they also occurred in the original PR #15794 |
Collaborator
Tests analyticsTotal tests: 4006 Click here to see the affected service packages
Action takenFound 142 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Several tests terminated during RECORDING mode. 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
|
🔴 The provider crashed while running the VCR tests in REPLAYING mode |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Collaborator
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
|
🔴 The provider crashed while running the VCR tests in REPLAYING mode |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
|
🔴 The provider crashed while running the VCR tests in REPLAYING mode |
Collaborator
|
🔴 The provider crashed while running the VCR tests in REPLAYING mode |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 5946 Click here to see the affected service packages
Action takenFound 457 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
|
/gcbrun |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 5951 Click here to see the affected service packages
Action takenFound 57 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
|
🔴 The provider crashed while running the VCR tests in RECORDING mode |
Member
Author
|
/gcbrun Likely transient. |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 5967 Click here to see the affected service packages
Action takenFound 58 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
|
🔴 The provider crashed while running the VCR tests in RECORDING mode |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
There may be some changes required for the build check that needs to be looked into, aside from values being inconsistent within update due to special cases (latest commit excludes them from identity generation): === RUN TestAccComputeTargetInstance_withSecurityPolicy
resource_compute_target_instance_test.go:32: Step 3/7 error: Error running apply: exit status 1
Error: Unexpected Identity Change: During the update operation, the Terraform Provider unexpectedly returned a different identity than the previously stored one.
This is always a problem with the provider and should be reported to the provider developer.
Planned Identity: cty.ObjectVal(map[string]cty.Value{"name":cty.StringVal("tf-test-up-pol-target-instancelbnd20vg1o"), "project":cty.StringVal("ci-test-project-188019"), "zone":cty.StringVal("southamerica-east1-a")})
New Identity: cty.ObjectVal(map[string]cty.Value{"name":cty.StringVal("tf-test-up-pol-target-instancelbnd20vg1o"), "project":cty.StringVal("ci-test-project-188019"), "zone":cty.StringVal("https://www.googleapis.com/compute/v1/projects/ci-test-project-188019/zones/southamerica-east1-a")})the build failing trigger appears to still be caused by: === RUN TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate
=== PAUSE TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate
=== CONT TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate
panic: test timed out after 4h0m0s
running tests:
TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate (4h0m0s)i'm assuming this panic was never caught until now? perhaps we can exclude this from VCR? There would have to be time spent to resolve it given that it's been flaky when looking at the TeamCity Test History for it @shuyama1 |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 5969 Click here to see the affected service packages
Action takenFound 52 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
Tests analyticsTotal tests: 5967 Click here to see the affected service packages
Action takenFound 46 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
|
🔴 The provider crashed while running the VCR tests in RECORDING mode |
Collaborator
|
🔴 The provider crashed while running the VCR tests in RECORDING mode |
Collaborator
|
@shuyama1 from latest run, the failed build comes from the same test as you mentioned: === CONT TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess
resource_sql_database_instance_test.go:3414: Step 8/13 error: Error running apply: exit status 1
Error: Error, failed to update instance settings for : googleapi: Error 400: Invalid request: The specified failover dr replica name ci-test-project-188019:tf-test-pg-sw-primary-otw0bzgksd must be one of the replicas of the primary instance ci-test-project-188019:tf-test-pg-sw-replica-rkmqa7h7lb., invalid
with google_sql_database_instance.original-replica,
on terraform_plugin_test.tf line 35, in resource "google_sql_database_instance" "original-replica":
35: resource "google_sql_database_instance" "original-replica" {
panic.go:615: Error running post-test destroy, there may be dangling resources: exit status 1
Error: Error, failed to delete instance tf-test-pg-sw-replica-rkmqa7h7lb: googleapi: Error 400: The requested operation is not valid for a replication master instance., errorReplicationMasterInvalidOperation
--- FAIL: TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess (1546.26s)
FAIL
FAIL github.com/hashicorp/terraform-provider-google-beta/google-beta/services/sql 1546.385s
FAIL
=== RUN TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess
=== PAUSE TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess
=== CONT TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess
resource_sql_database_instance_test.go:3336: Step 8/13 error: Error running apply: exit status 1
Error: Error, failed to update instance settings for : googleapi: Error 400: Invalid request: The specified failover dr replica name ci-test-project-188019:tf-test-mysql-sw-primary-h901esb47e must be one of the replicas of the primary instance ci-test-project-188019:tf-test-mysql-sw-replica-e8v8xt38r6., invalid
with google_sql_database_instance.original-replica,
on terraform_plugin_test.tf line 35, in resource "google_sql_database_instance" "original-replica":
35: resource "google_sql_database_instance" "original-replica" {
panic.go:615: Error running post-test destroy, there may be dangling resources: exit status 1
Error: Error, failed to delete instance tf-test-mysql-sw-replica-e8v8xt38r6: googleapi: Error 400: The requested operation is not valid for a replication master instance., errorReplicationMasterInvalidOperation
--- FAIL: TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess (1577.80s)
FAIL
FAIL github.com/hashicorp/terraform-provider-google-beta/google-beta/services/sql 1577.941s
FAIL
=== RUN TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate
=== PAUSE TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate
=== CONT TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate
panic: test timed out after 4h0m0s
running tests:
TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate (4h0m0s)
goroutine 10436 [running]:
testing.(*M).startAlarm.func1()
/usr/local/go/src/testing/testing.go:2682 +0x345
created by time.goFunc
/usr/local/go/src/time/sleep.go:215 +0x2d
goroutine 1 [chan receive, 240 minutes]:
testing.tRunner.func1()
/usr/local/go/src/testing/testing.go:1891 +0x451
testing.tRunner(0xc000902e00, 0xc00006dc70)
/usr/local/go/src/testing/testing.go:1940 +0x123
testing.runTests(0xc001505818, {0x93d86a0, 0xf, 0xf}, {0x7?, 0xc000930b40?, 0x93f7020?})
/usr/local/go/src/testing/testing.go:2475 +0x4b4
testing.(*M).Run(0xc0010c3900)
/usr/local/go/src/testing/testing.go:2337 +0x63a
main.main()
_testmain.go:75 +0x9b
goroutine 67 [select]:
github.com/golang/glog.(*fileSink).flushDaemon(0x93f70b8)
/go/pkg/mod/github.com/golang/glog@v1.2.5/glog_file.go:380 +0xb4
created by github.com/golang/glog.init.1 in goroutine 1
/go/pkg/mod/github.com/golang/glog@v1.2.5/glog_file.go:188 +0x1ae
goroutine 31 [sync.WaitGroup.Wait, 239 minutes]:
sync.runtime_SemacquireWaitGroup(0xc004c82500?, 0x80?)
/usr/local/go/src/runtime/sema.go:114 +0x2e
sync.(*WaitGroup).Wait(0xc0032db770)
/usr/local/go/src/sync/waitgroup.go:206 +0x85 |
Member
Author
|
/gcbrun |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 5966 Click here to see the affected service packages
Action takenFound 33 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
|
🔴 The provider crashed while running the VCR tests in RECORDING mode |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 5966 Click here to see the affected service packages
Action takenFound 31 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Several tests terminated during RECORDING mode. 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support of
identityschema support while also addingidentityschema generation withinMMv1resources along withresource-identitytesting.For more information on the identity block itself see the following documentation:
This is copied from the feature branch #15794 authored by @BBBmau
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.