-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add support for firestoreDataAccessMode, mongodbCompatibleDataAcessMode, and realtimeUpdatesMode parameters in the google_firestore_database resource
#16242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NickChittle
wants to merge
7
commits into
GoogleCloudPlatform:main
Choose a base branch
from
NickChittle:data_access_modes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−0
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bdb70cc
Add support for firestoreDataAccessMode, mongodbCompatibleDataAcessMo…
NickChittle 0714034
Fix template usage
NickChittle 871cbaf
Fix tab/space alignment
NickChittle 9e34ab5
Fix template
NickChittle cf471e5
Fix template oopsie
NickChittle 1bb52d5
Small fixes
NickChittle 6b6c704
Make sure example database is able to be deleted
NickChittle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
mmv1/templates/terraform/examples/firestore_database_data_access.tf.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| resource "google_firestore_database" "{{$.PrimaryResourceId}}" { | ||
| project = "{{index $.TestEnvVars "project_id"}}" | ||
| name = "{{index $.Vars "database_id"}}" | ||
| location_id = "nam5" | ||
| type = "FIRESTORE_NATIVE" | ||
| database_edition = "ENTERPRISE" | ||
| firestore_data_access_mode = "DATA_ACCESS_MODE_ENABLED" | ||
| mongodb_compatible_data_access_mode = "DATA_ACCESS_MODE_DISABLED" | ||
| realtime_updates_mode = "REALTIME_UPDATES_MODE_DISABLED" | ||
| deletion_policy = "DELETE" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if one of these is set for a Datastore mode database? (Same question about Mongo-compat API for Datastore mode).
And if the Firestore API data access mode is enabled, does that allow using the Datastore API against that database?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are blocked by the backend.
Trying to create an ENTERPRISE database in datastore-mode throws this error:
INVALID_ARGUMENT: Enterprise Edition is only supported for Firestore Native databases.Trying to create a STANDARD database datastore-mode with one of the data-access modes throws this error:
INVALID_ARGUMENT: Only Enterprise Edition is allowed to set Data Access Mode.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. In that case let's just leave something in the descriptions specifying the allowed editions and modes.