Skip to content

Added backupDR flag#16269

Open
agamkrbit wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
agamkrbit:filestore-backupdr
Open

Added backupDR flag#16269
agamkrbit wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
agamkrbit:filestore-backupdr

Conversation

@agamkrbit
Copy link

@agamkrbit agamkrbit commented Feb 2, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

filestore: added `source_backupdr_backup` field to `instance` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 2, 2026
@agamkrbit
Copy link
Author

/gcbrun

@agamkrbit agamkrbit marked this pull request as ready for review February 2, 2026 09:15
@github-actions github-actions bot requested a review from slevenick February 2, 2026 09:16
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/filestore and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 2, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 128 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 128 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 47 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 22
Passed tests: 20
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • filestore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFilestoreInstance_restoreBackupDR
  • TestAccFilestoreInstance_restoreBackupDR_conflicts

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_restoreBackupDR [Error message] [Debug log]
TestAccFilestoreInstance_restoreBackupDR_conflicts [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 10, 2026
@github-actions github-actions bot requested a review from slevenick February 10, 2026 06:02
@github-actions
Copy link

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/filestore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants