Skip to content

Biglake namespace resource#16280

Merged
melinath merged 33 commits intoGoogleCloudPlatform:mainfrom
rambleraptor:namespace_resource
Feb 12, 2026
Merged

Biglake namespace resource#16280
melinath merged 33 commits intoGoogleCloudPlatform:mainfrom
rambleraptor:namespace_resource

Conversation

@rambleraptor
Copy link
Contributor

@rambleraptor rambleraptor commented Feb 2, 2026

Bit of a weird situation:

The BigLake Iceberg Namespace resource follows the Iceberg REST Catalog specification. That means that it isn't a Google compliant API at all! IAM still follows the traditional Google API structure. With that in mind, I've gone ahead and built out the resources in the most Magic Modules way I could.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_biglake_iceberg_namespace`

@rambleraptor rambleraptor marked this pull request as draft February 2, 2026 23:57
@github-actions github-actions bot requested a review from NickElliot February 2, 2026 23:57
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

1 similar comment
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@rambleraptor rambleraptor marked this pull request as ready for review February 3, 2026 21:21
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@github-actions github-actions bot requested a review from melinath February 11, 2026 06:21
@rambleraptor
Copy link
Contributor Author

@melinath changes made! Thanks for the review!

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

1 similar comment
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@rambleraptor
Copy link
Contributor Author

@melinath looks like tests are passing! thanks for the help

@melinath
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 1771 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 11 files changed, 1771 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 533 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6025
Passed tests: 5401
Skipped tests: 622
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
  • TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@melinath
Copy link
Member

LGTM, failing tests look unrelated.

@melinath
Copy link
Member

wj-chen is OOO, so I'm moving forward with merge.

@melinath melinath added this pull request to the merge queue Feb 12, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 4a69edf Feb 12, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants