Skip to content

feat: (storage) added google_managed_encryption_enforcement_config, customer_managed_encryption_enforcement_config and customer_supplied_encryption_enforcement_config to google_storage_bucket resource#16307

Draft
gurusai-voleti wants to merge 12 commits intoGoogleCloudPlatform:mainfrom
gurusai-voleti:bucket_encryption_config_fields

Conversation

@gurusai-voleti
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storage: added `google_managed_encryption_enforcement_config`, `customer_managed_encryption_enforcement_config` and `customer_supplied_encryption_enforcement_config` to `google_storage_bucket` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 340 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 3 files changed, 340 insertions(+), 8 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_bucket (664 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_bucket" "primary" {
  encryption {
    customer_managed_encryption_enforcement_config {
      effective_time = # value needed
    }
    customer_supplied_encryption_enforcement_config {
      effective_time = # value needed
    }
    google_managed_encryption_enforcement_config {
      effective_time = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_storage_bucket
    • Expected Document Path: /website/docs/r/storage_bucket.html.markdown
    • Fields: [encryption.customer_managed_encryption_enforcement_config.effective_time encryption.customer_managed_encryption_enforcement_config.restriction_mode encryption.customer_supplied_encryption_enforcement_config.effective_time encryption.customer_supplied_encryption_enforcement_config.restriction_mode encryption.google_managed_encryption_enforcement_config.effective_time encryption.google_managed_encryption_enforcement_config.restriction_mode]

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 340 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 3 files changed, 340 insertions(+), 8 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_bucket (664 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_bucket" "primary" {
  encryption {
    customer_managed_encryption_enforcement_config {
      effective_time = # value needed
    }
    customer_supplied_encryption_enforcement_config {
      effective_time = # value needed
    }
    google_managed_encryption_enforcement_config {
      effective_time = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 339 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 3 files changed, 339 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 339 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 3 files changed, 339 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 131
Passed tests: 118
Skipped tests: 10
Affected tests: 3

Click here to see the affected service packages
  • storage

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageBucket_encryptionCmek
  • TestAccStorageBucket_encryptionCsek
  • TestAccStorageBucket_encryptionGmek

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccStorageBucket_encryptionCmek [Error message] [Debug log]
TestAccStorageBucket_encryptionCsek [Error message] [Debug log]
TestAccStorageBucket_encryptionGmek [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 351 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 4 files changed, 351 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 131
Passed tests: 118
Skipped tests: 10
Affected tests: 3

Click here to see the affected service packages
  • storage

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageBucket_encryptionCmek
  • TestAccStorageBucket_encryptionCsek
  • TestAccStorageBucket_encryptionGmek

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccStorageBucket_encryptionCmek [Error message] [Debug log]
TestAccStorageBucket_encryptionCsek [Error message] [Debug log]
TestAccStorageBucket_encryptionGmek [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 345 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 4 files changed, 345 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 131
Passed tests: 118
Skipped tests: 10
Affected tests: 3

Click here to see the affected service packages
  • storage

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageBucket_encryptionCmek
  • TestAccStorageBucket_encryptionCsek
  • TestAccStorageBucket_encryptionGmek

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 131
Passed tests: 118
Skipped tests: 10
Affected tests: 3

Click here to see the affected service packages
  • storage

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageBucket_encryptionCmek
  • TestAccStorageBucket_encryptionCsek
  • TestAccStorageBucket_encryptionGmek

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccStorageBucket_encryptionCmek [Error message] [Debug log]
TestAccStorageBucket_encryptionCsek [Error message] [Debug log]
TestAccStorageBucket_encryptionGmek [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccStorageBucket_encryptionCmek [Error message] [Debug log]
TestAccStorageBucket_encryptionCsek [Error message] [Debug log]
TestAccStorageBucket_encryptionGmek [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 131
Passed tests: 118
Skipped tests: 10
Affected tests: 3

Click here to see the affected service packages
  • storage

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageBucket_encryptionCmek
  • TestAccStorageBucket_encryptionCsek
  • TestAccStorageBucket_encryptionGmek

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccStorageBucket_encryptionCmek [Error message] [Debug log]
TestAccStorageBucket_encryptionCsek [Error message] [Debug log]
TestAccStorageBucket_encryptionGmek [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 345 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 4 files changed, 345 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 131
Passed tests: 118
Skipped tests: 10
Affected tests: 3

Click here to see the affected service packages
  • storage

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageBucket_encryptionCmek
  • TestAccStorageBucket_encryptionCsek
  • TestAccStorageBucket_encryptionGmek

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccStorageBucket_encryptionCmek [Error message] [Debug log]
TestAccStorageBucket_encryptionCsek [Error message] [Debug log]
TestAccStorageBucket_encryptionGmek [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants