-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Update development guide #3185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update development guide #3185
Conversation
…troubleshooting steps
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bourgeoisor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
| **Install skaffold:** | ||
| ```sh | ||
| # Linux | ||
| curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/latest/skaffold-linux-amd64 | ||
| chmod +x skaffold | ||
| sudo mv skaffold /usr/local/bin/ | ||
|
|
||
| # macOS | ||
| brew install skaffold | ||
|
|
||
| # Or download from: https://skaffold.dev/docs/install/ | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather not have these instructions here, since we'd be duplicating a source of truth that already exists (which is linked in the doc: https://skaffold.dev/docs/install/)
| **If you encounter build errors** (see Troubleshooting section below), use pre-built images instead: | ||
| ```shell | ||
| kubectl apply -f ./release/kubernetes-manifests.yaml | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this text. This doc is for developing on Bank of Anthos, so pulling pre-built images defeats the purpose of this guide)
|
@ricardoamaro you will also have to sign the CLA. See: #3185 (comment) |
…troubleshooting steps
Background
Fixes
Change Summary
Additional Notes
Testing Procedure
Related PRs or Issues