Skip to content

Fix validation of the post-training, notebook DAGs #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alfredyu-cienet merged 1 commit into from
Feb 12, 2026
Merged

Fix validation of the post-training, notebook DAGs #1185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions dags/post_training/util/notebook_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,15 @@ def build_notebook_execution_command(
f"{export_prefix}papermill {output_nb} {output_nb} --log-output"
)

# Verify the success message exists in the notebook's output.
# We 'grep -v "print("' to ignore the Python source code line
# and ensure we are matching an actual execution result.
expected_completed_message = "Training Completed Successfully!"
verification_script = textwrap.dedent(
f"""
if ! grep -q "Training Completed Successfully!" {output_nb}; then
echo "Error: Notebook did not report successful completion."
set -o pipefail
if ! grep "{expected_completed_message}" {output_nb} | grep -vq "print("; then
echo "Error: Notebook did not report '{expected_completed_message}'."
exit 1
fi
"""
Expand Down
Loading