Fix: jobset based push node_pool_name to nodeselector#1187
Merged
alfredyu-cienet merged 1 commit intoGoogleCloudPlatform:masterfrom Feb 12, 2026
Merged
Conversation
…to desired NodePool This change fixes a critical scheduling issue where JobSet pods were being dispatched to arbitrary node pools instead of the intended ones, and extends the fix to support multi-node-pool environments. Problem: Previously, the JobSet YAML template had no nodeSelector for the GKE node pool. In environments with multiple node pools, Kubernetes would schedule pods on any available nodes. This led to cases where a Rollback was performed on Node Pool A, but the JobSet pods were actually running on Node Pool B, resulting in inaccurate TTR (Time To Recovery) metrics. Additionally, for DAGs like `tpu_info_format_validation_dag` that create two node pools for the same workload, pinning to a single node pool name would leave the second pool unused.
alfredyu-cienet
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical scheduling issue where JobSet pods were being dispatched to arbitrary node pools instead of the intended ones, and extends the fix to support multi-node-pool environments.
Problem: Previously, the JobSet YAML template had no nodeSelector for the GKE node pool. In environments with multiple node pools, Kubernetes would schedule pods on any available nodes. This led to cases where a Rollback was performed on Node Pool A, but the JobSet pods were actually running on Node Pool B, resulting in inaccurate TTR (Time To Recovery) metrics. Additionally, for DAGs like
tpu_info_format_validation_dagthat create two node pools for the same workload, pinning to a single node pool name would leave the second pool unused.Technical Implementation
Added a dynamic
$node_pool_selectorto the JobSet YAML template that supports scheduling modes:tpu-observability/jobset-group: <jobset_name>applied to all participating node pools viagcloud --node-labelsat creation time, allowing the K8s scheduler to dispatch pods across multiple pools.Test
jobset_ttr_rollback.pytest result: https://3450723b279f4f47af5e5f22135026a7-dot-us-central1.composer.googleusercontent.com/dags/jobset_rollback_ttr/grid?tab=logs&dag_run_id=manual__2026-02-10T12%3A20%3A29.774345%2B00%3A00&task_id=v6e.create_node_pooltpu_info_format_validation_dag.pytest result: https://3450723b279f4f47af5e5f22135026a7-dot-us-central1.composer.googleusercontent.com/dags/tpu_info_format_validation_dag/grid?dag_run_id=manual__2026-02-09T14%3A12%3A31.677533%2B00%3A00&tab=graph&task_id=v6e.create_node_poolChecklist
Before submitting this PR, please make sure (put X in square brackets):