-
Notifications
You must be signed in to change notification settings - Fork 62
Add Qwen3-Next tests to MaxText_MoE DAG #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """A standalone DAG to test the Qwen3-Next 80B script with a custom Docker image.""" | ||
|
|
||
| import datetime | ||
| from airflow import models | ||
| from dags import composer_env | ||
| from dags.common import test_owner | ||
| from dags.common.vm_resource import XpkClusters | ||
| from dags.multipod.configs import gke_config | ||
|
|
||
| # Retrieve the HF_TOKEN from Airflow variables | ||
| HF_TOKEN = models.Variable.get("HF_TOKEN", None) | ||
|
|
||
| with models.DAG( | ||
| dag_id="qwen3_next_custom_image_test", | ||
| schedule=None, # Set to None so it only runs when manually triggered | ||
| tags=[ | ||
| "maxtext", | ||
| "tpu", | ||
| "qwen3", | ||
| "v5p-128", | ||
| ], | ||
| start_date=datetime.datetime(2024, 1, 1), | ||
| catchup=False, | ||
| ) as dag: | ||
| # Your specified custom docker image | ||
| custom_docker_image = "gcr.io/tpu-prod-env-multipod/maxtext_stable_stack_candidate:rbierneni-qwen-test" | ||
|
|
||
| # Single unchained test configuration | ||
| test_qwen3_next = gke_config.get_gke_config( | ||
| time_out_in_min=90, | ||
| test_name="maxtext_qwen3_next_80b_test", | ||
| run_model_cmds=( | ||
| f"export HF_TOKEN={HF_TOKEN}; export BASE_OUTPUT_PATH=$GCS_OUTPUT; bash tests/end_to_end/tpu/qwen/next/qwen3-next-80b-a3b/2_test_qwen3_next_80b_a3b.sh", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To confirm this test is only checking for runtime errors ? do you also plan on adding a tests for logits now or in the future ?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The test is running this script: https://github.com/AI-Hypercomputer/maxtext/blob/040c71b73616d768b141da07292fb0417164846c/tests/end_to_end/tpu/qwen/next/qwen3-next-80b-a3b/2_test_qwen3_next_80b_a3b.sh It does:
It should cover logit comparision, runtime errors, config checks, train/decoding support, etc. Pretty much all end-to-end model checks. |
||
| ), | ||
| docker_image=custom_docker_image, | ||
| test_owner=test_owner.ROHAN_B, # Update the owner if necessary | ||
| cluster=XpkClusters.TPU_V5P_128_CLUSTER, | ||
| ).run() | ||
|
|
||
| # No chained dependencies required since there is only one task | ||
| test_qwen3_next | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add yourself as the owner for
qwen3-next-80b?We can do something like the
maxtext_end_to_endDAG, where the owner is different across tests:ml-auto-solutions/dags/multipod/maxtext_end_to_end.py
Lines 61 to 71 in 26acd7b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I have added myself for the qwen3 next test. For the other tests, i let it default to you.