Skip to content

Conversation

@jama22
Copy link
Contributor

@jama22 jama22 commented Nov 19, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@jama22 jama22 requested review from a team as code owners November 19, 2024 23:08
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: cloudfunctions Issues related to the Cloud Run functions API. asset: pattern DEE Asset tagging - Pattern. labels Nov 19, 2024
Copy link
Contributor

@code-review-assist-experimental code-review-assist-experimental bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jama22 and reviewers,

I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:

This pull request updates the README.md file in the functions/ directory to reflect the rebranding of Cloud Functions to Cloud Run functions. The main changes are:

  • Updated README introduction: The introduction now accurately reflects the new name and provides a clear explanation of the two versions of Cloud Run functions (1st gen and 2nd gen, formerly known as Cloud Functions 1st and 2nd gen). This includes links to the relevant documentation.
  • Updated sample list: The list of samples in the README has been updated to reflect the new structure and location of some samples. Specifically, the Cloud Pub/Sub sample has been moved to the v2/ directory.

The changes are concise and well-documented, making the README easier to understand for users. The updated README accurately reflects the current state of Cloud Run functions and their associated samples.


And now, a little haiku to lighten the mood:

Cloud Run's new name,
Docs updated, clear and bright,
Code flows smoothly on.

Looking forward to a thorough review!

@iennae iennae merged commit 0e00257 into GoogleCloudPlatform:main Nov 19, 2024
7 of 131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants