-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: compute_disk_regional_replicated/attach_regional_disk/instance_replicated_disk #3922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gryczj and reviewers,
I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:
This pull request adds a new sample demonstrating how to create a regional replicated Compute Engine disk. The main changes are in compute/disks/createRegionalReplicatedDisk.js, which implements the functionality, and compute/test/createRegionalReplicatedDisk.test.js, which provides unit tests for the new sample. A minor change was also made to compute/test/util.js to hardcode the project ID in the deleteDisk function for testing purposes. The intent is to provide a clear and concise example of creating a regionally replicated disk, including error handling and cleanup.
If there's anything unclear or missing, please let me know. I'll provide a more detailed review shortly.
And now, a little haiku to lighten the mood:
Disks spin, data flows,
Regional replication's grace,
Clouds keep data safe.
Thanks!
0cdadae to
7bbe8c6
Compare
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
4d95fdc to
b070a22
Compare
b070a22 to
13de59a
Compare
f19d617 to
22f1c60
Compare
e1657d9 to
2fd7e2b
Compare
2fd7e2b to
580e8ea
Compare
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.