Skip to content

Conversation

@gryczj
Copy link
Contributor

@gryczj gryczj commented Nov 20, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj requested review from a team as code owners November 20, 2024 14:44
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Nov 20, 2024
Copy link
Contributor

@code-review-assist-experimental code-review-assist-experimental bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gryczj and reviewers,

I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:

This pull request adds a new sample demonstrating how to create a regional replicated Compute Engine disk. The main changes are in compute/disks/createRegionalReplicatedDisk.js, which implements the functionality, and compute/test/createRegionalReplicatedDisk.test.js, which provides unit tests for the new sample. A minor change was also made to compute/test/util.js to hardcode the project ID in the deleteDisk function for testing purposes. The intent is to provide a clear and concise example of creating a regionally replicated disk, including error handling and cleanup.

If there's anything unclear or missing, please let me know. I'll provide a more detailed review shortly.

And now, a little haiku to lighten the mood:

Disks spin, data flows,
Regional replication's grace,
Clouds keep data safe.

Thanks!

@gryczj gryczj force-pushed the compute_disk_regional_replicated branch from 0cdadae to 7bbe8c6 Compare November 20, 2024 14:45
@snippet-bot
Copy link

snippet-bot bot commented Nov 20, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 20, 2024
@gryczj gryczj force-pushed the compute_disk_regional_replicated branch from 4d95fdc to b070a22 Compare November 21, 2024 09:14
@gryczj gryczj changed the title feat: compute_disk_regional_replicated feat: compute_disk_regional_replicated/attach_regional_disk Nov 21, 2024
@gryczj gryczj force-pushed the compute_disk_regional_replicated branch from b070a22 to 13de59a Compare November 21, 2024 17:50
@gryczj gryczj changed the title feat: compute_disk_regional_replicated/attach_regional_disk feat: compute_disk_regional_replicated/attach_regional_disk(force) Nov 21, 2024
@gryczj gryczj requested a review from iennae November 22, 2024 13:33
@gryczj gryczj changed the title feat: compute_disk_regional_replicated/attach_regional_disk(force) feat: compute_disk_regional_replicated/attach_regional_disk/instance_replicated_disk Nov 25, 2024
@gryczj gryczj force-pushed the compute_disk_regional_replicated branch from f19d617 to 22f1c60 Compare November 25, 2024 14:55
@gryczj gryczj force-pushed the compute_disk_regional_replicated branch 2 times, most recently from e1657d9 to 2fd7e2b Compare December 3, 2024 10:41
@gryczj gryczj force-pushed the compute_disk_regional_replicated branch from 2fd7e2b to 580e8ea Compare December 4, 2024 13:49
@gryczj gryczj requested a review from m-strzelczyk December 4, 2024 13:50
@BigBlackWolf BigBlackWolf self-requested a review December 5, 2024 11:55
@iennae iennae merged commit c21920f into main Dec 5, 2024
56 of 57 checks passed
@iennae iennae deleted the compute_disk_regional_replicated branch December 5, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants