Skip to content

fix: (data_catalog) migrate region tag in createFilesetEntry.js #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glasnt merged 5 commits into from
Jan 20, 2025
Merged

fix: (data_catalog) migrate region tag in createFilesetEntry.js #3948

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d75cdaa
fix: (data_catalog) migrate region tag in createFilesetEntry.js
hivanalejandro Jan 14, 2025
dbdab85
fix: (data_catalog) update region tag in createFilesetEntry.js
hivanalejandro Jan 16, 2025
dc0396f
Merge branch 'main' into hivanalejandro-migrate-region-step1-389810838
iennae Jan 16, 2025
d080e91
Merge branch 'main' into hivanalejandro-migrate-region-step1-389810838
NimJay Jan 16, 2025
4b7657c
Merge branch 'main' into hivanalejandro-migrate-region-step1-389810838
iennae Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions datacatalog/cloud-client/createFilesetEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const main = async (
entryGroupId,
entryId
) => {
// [START data_catalog_create_fileset_tag]
Copy link

@ghost ghost Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new region tag should only appear once.

Suggested change
// [START data_catalog_create_fileset_tag]
// [START data_catalog_create_fileset_tag]

// [START datacatalog_create_fileset_tag]
// -------------------------------
// Import required modules.
Expand Down Expand Up @@ -101,6 +102,7 @@ const main = async (

console.log(response);
// [END datacatalog_create_fileset_tag]
// [END data_catalog_create_fileset_tag]
Copy link

@ghost ghost Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new region tag should only appear once.

Suggested change
// [END data_catalog_create_fileset_tag]
// [END data_catalog_create_fileset_tag]

};

// node createFilesetEntry.js <projectId> <entryGroupId> <entryId>
Expand Down
Loading