Skip to content

Conversation

@glasnt
Copy link
Contributor

@glasnt glasnt commented Mar 3, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: cloudsql Issues related to the Cloud SQL for MySQL API. asset: pattern DEE Asset tagging - Pattern. labels Mar 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request migrates the CI configuration for the cloud-sql/mysql/mysql sample. It removes the sample from the nodejs-prod.jsonc file, which seems to be a list of samples to exclude from CI, and adds a ci-setup.json file to define environment variables for the CI environment. The PR description indicates that this fixes an issue, although the issue number is not specified.

Highlights

  • CI Migration: The pull request migrates the CI configuration for the cloud-sql/mysql/mysql sample.
  • Exclusion Removal: The cloud-sql/mysql/mysql sample is removed from the list of excluded samples in nodejs-prod.jsonc.
  • Environment Variables: A ci-setup.json file is added to define INSTANCE_HOST and DB_PORT environment variables for the CI environment.

Changelog

  • .github/config/nodejs-prod.jsonc
    • Removed cloud-sql/mysql/mysql from the list of samples excluded from CI due to a previous error.
  • cloud-sql/mysql/mysql/ci-setup.json
    • Added a new file to define CI environment variables.
    • Defined INSTANCE_HOST as 127.0.0.1.
    • Defined DB_PORT as 1433.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


The CI pipeline, a digital stream,
Where code flows, fulfilling a dream.
From commit to test, a rigorous race,
Ensuring quality, with speed and with grace.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request migrates the MySQL CI setup to a new configuration. The changes involve removing a failing test configuration and adding environment variables for the test setup. Overall, the changes seem straightforward and necessary for the CI to function correctly.

Merge Readiness

The changes appear to be necessary for the CI to function correctly. Since there are no review comments, I believe the pull request is ready to be merged. However, I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

@glasnt
Copy link
Contributor Author

glasnt commented Mar 4, 2025

Larger changes to the testing system are required for this PR, around Cloud SQL Auth Proxy

@glasnt glasnt closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudsql Issues related to the Cloud SQL for MySQL API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant