-
Notifications
You must be signed in to change notification settings - Fork 2k
ci(mysql/mysql): migrate to new ci #4003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request migrates the CI configuration for the cloud-sql/mysql/mysql sample. It removes the sample from the nodejs-prod.jsonc file, which seems to be a list of samples to exclude from CI, and adds a ci-setup.json file to define environment variables for the CI environment. The PR description indicates that this fixes an issue, although the issue number is not specified.
Highlights
- CI Migration: The pull request migrates the CI configuration for the
cloud-sql/mysql/mysqlsample. - Exclusion Removal: The
cloud-sql/mysql/mysqlsample is removed from the list of excluded samples innodejs-prod.jsonc. - Environment Variables: A
ci-setup.jsonfile is added to defineINSTANCE_HOSTandDB_PORTenvironment variables for the CI environment.
Changelog
- .github/config/nodejs-prod.jsonc
- Removed
cloud-sql/mysql/mysqlfrom the list of samples excluded from CI due to a previous error.
- Removed
- cloud-sql/mysql/mysql/ci-setup.json
- Added a new file to define CI environment variables.
- Defined
INSTANCE_HOSTas127.0.0.1. - Defined
DB_PORTas1433.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
The CI pipeline, a digital stream,
Where code flows, fulfilling a dream.
From commit to test, a rigorous race,
Ensuring quality, with speed and with grace.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request migrates the MySQL CI setup to a new configuration. The changes involve removing a failing test configuration and adding environment variables for the test setup. Overall, the changes seem straightforward and necessary for the CI to function correctly.
Merge Readiness
The changes appear to be necessary for the CI to function correctly. Since there are no review comments, I believe the pull request is ready to be merged. However, I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
|
Larger changes to the testing system are required for this PR, around Cloud SQL Auth Proxy |
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.