Skip to content

fix: ensure all retry.sh failures fail exit 1 #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glasnt merged 7 commits into from
Mar 26, 2025
Merged

fix: ensure all retry.sh failures fail exit 1 #4037

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
36191fb
fix: ensure all retry.sh failures fail exit 1
glasnt Mar 24, 2025
a4cc3a8
auto format
glasnt Mar 24, 2025
bbd94dc
Merge branch 'main' into exit1
iennae Mar 25, 2025
7f88c34
Format Document
glasnt Mar 26, 2025
dad8ec2
revert Format Document (does not match gts)
glasnt Mar 26, 2025
4675f09
manual gts lint
glasnt Mar 26, 2025
2b5260d
Merge branch 'main' into exit1
glasnt Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion run/markdown-preview/editor/test/retry.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ do
if ((attempt_num==max_attempts))
then
echo "Attempt $attempt_num / $max_attempts failed! No more retries left!"
exit
exit 1
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding exit 1 here ensures that the script returns a failure status when all retries are exhausted. This is important for signaling to calling scripts that the operation failed after multiple attempts.

Consider adding a comment explaining why exit 1 is used here for clarity.

Suggested change
echo "Attempt $attempt_num / $max_attempts failed! No more retries left!"
exit
exit 1
exit 1 # Exit with a non-zero status code to indicate failure after max retries

else
echo "Attempt $attempt_num / $max_attempts failed!"
sleep $((attempt_num++))
Expand Down
2 changes: 1 addition & 1 deletion run/markdown-preview/renderer/test/retry.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ do
if ((attempt_num==max_attempts))
then
echo "Attempt $attempt_num / $max_attempts failed! No more retries left!"
exit
exit 1
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the other retry.sh file, adding exit 1 here is essential for proper error signaling. A non-zero exit code indicates that the retried operation ultimately failed.

Consider adding a comment explaining why exit 1 is used here for clarity.

Suggested change
echo "Attempt $attempt_num / $max_attempts failed! No more retries left!"
exit
exit 1
exit 1 # Exit with a non-zero status code to indicate failure after max retries

else
echo "Attempt $attempt_num / $max_attempts failed!"
sleep $((attempt_num++))
Expand Down
Loading