debug: workspace to test migrating sql samples to new ci [donotmerge]

[glasnt]

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
• Tests pass: npm test (see Testing)
• Lint pass: npm run lint (see Style)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[gemini-code-assist]

Hello @glasnt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request migrates the SQL samples to the new CI. It involves changes to the nodejs-dev.jsonc and nodejs-prod.jsonc files. Specifically, it adds several cloud-sql samples to the nodejs-dev.jsonc file to be included in the CI, and removes those same samples from the nodejs-prod.jsonc file, presumably because they are now passing in the development CI environment.

Highlights

• CI Migration: The primary goal is to migrate the SQL samples to the new CI pipeline.
• Development CI Inclusion: The cloud-sql samples are added to the nodejs-dev.jsonc configuration.
• Production CI Exclusion: The cloud-sql samples are removed from the nodejs-prod.jsonc configuration.

Changelog

• .github/config/nodejs-dev.jsonc
  • Added cloud-sql samples including mysql, mysql2, postgres/knex, sqlserver/mssql, and sqlserver/tedious to the list of samples to be tested in the development CI.
• .github/config/nodejs-prod.jsonc
  • Removed cloud-sql samples including mysql, mysql2, postgres/knex, sqlserver/mssql, and sqlserver/tedious from the list of samples to be tested in the production CI. These were previously marked as untested and failing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Did you know?

MySQL is named after co-founder Michael 'Monty' Widenius's daughter, My.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request migrates SQL samples to the new CI. The changes involve updating the nodejs-dev.jsonc and nodejs-prod.jsonc files to include and exclude certain SQL samples, respectively. Overall, the changes seem straightforward and necessary for the CI migration.

Summary of Findings

• Inclusion of SQL samples in nodejs-dev.jsonc: The addition of SQL samples in nodejs-dev.jsonc seems correct, ensuring these samples are included in the development CI.
• Removal of SQL samples in nodejs-prod.jsonc: The removal of SQL samples from nodejs-prod.jsonc is likely due to previous failures or instability, which is a reasonable step for a stable production CI.
• TODO comments in nodejs-prod.jsonc: The nodejs-prod.jsonc file contains TODO comments indicating that some samples need fixing. It's important to track these and address them in future iterations.

Merge Readiness

The pull request appears to be ready for merging, as it addresses the migration of SQL samples to the new CI. The removal of failing samples from the production CI is a pragmatic approach. However, it's crucial to keep track of the TODO comments in nodejs-prod.jsonc and address the underlying issues in future PRs. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.