Skip to content

chore(gae): Migrate region tags from build-an-app #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glasnt merged 2 commits into from
Mar 27, 2025
Merged

chore(gae): Migrate region tags from build-an-app #4045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ee7a1c
chore(gae): Migrate region tags from build-an-app
hivanalejandro Mar 26, 2025
5355f5f
fix(gae): Fix linting issues
hivanalejandro Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions appengine/building-an-app/build/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# [START gae_build_app_yaml_node]
# [START app_yaml]
# [START gae_app_yaml]
runtime: nodejs20
# [END gae_app_yaml]
# [END app_yaml]
# [END gae_build_app_yaml_node]
Comment on lines +14 to +20
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The region tag gae_build_app_yaml_node encapsulates the entire app.yaml content. Consider if this is the intended scope, or if it should only wrap the runtime setting to be more specific.

# [START gae_build_app_yaml_node]
runtime: nodejs20
# [END gae_build_app_yaml_node]

5 changes: 2 additions & 3 deletions appengine/building-an-app/build/test/server.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,14 @@ const supertest = require('supertest');
const path = require('path');
const app = require(path.join(__dirname, '../', 'server.js'));


describe('gae_app', () => {
it('should be listening', async () => {
await supertest(app).get('/').expect(200);
});
})
});

describe('gae_build_web_server_app', () => {
it('should be listening', async () => {
await supertest(app).get('/').expect(200);
});
})
});
2 changes: 2 additions & 0 deletions appengine/building-an-app/update/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# [START gae_update_app_yaml_node]
# [START gae_app_yaml]
# [START app_yaml]
runtime: nodejs20
# [END app_yaml]
# [END gae_app_yaml]
# [END gae_update_app_yaml_node]
Comment on lines +14 to +20
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the build/app.yaml, the gae_update_app_yaml_node tag encapsulates the entire file. Ensure this scope is intentional, or narrow it down to the runtime setting for better granularity.

# [START gae_update_app_yaml_node]
runtime: nodejs20
# [END gae_update_app_yaml_node]

Loading