chore(compute): migrate to new CI

.github/config/nodejs-dev.jsonc

@@ -109,6 +109,7 @@
     "cloudbuild",
     "composer",
     "composer/functions/composer-storage-trigger",
+    "compute",
     "contact-center-insights",
     "container",
     "container-analysis/snippets",

.github/config/nodejs-prod.jsonc

@@ -79,7 +79,6 @@
     "automl", // (untested) FAILED_PRECONDITION: Google Cloud AutoML Natural Language was retired on March 15, 2024. Please migrate to Vertex AI instead
     "cloud-sql/sqlserver/mssql", // (untested) TypeError: The "config.server" property is required and must be of type string.
     "cloud-sql/sqlserver/tedious", // (untested) TypeError: The "config.server" property is required and must be of type string.
-    "compute", // GoogleError: The resource 'projects/long-door-651/zones/us-central1-a/disks/disk-from-pool-name' was not found
     "dataproc", // GoogleError: Error submitting create cluster request: Multiple validation errors
     "datastore/functions", // [ERR_REQUIRE_ESM]: require() of ES Module
     "dialogflow-cx", // NOT_FOUND: com.google.apps.framework.request.NotFoundException: Agent 'undefined' does not exist

compute/ci-setup.json

@@ -0,0 +1,5 @@
+
+{
+  "_justification": "Compute tests take longer to run",
+  "timeout-minutes": 120
+}

compute/package.json

@@ -11,7 +11,8 @@
     "*.js"
   ],
   "scripts": {
-    "test": "c8 mocha -p -j 2 test --timeout 1200000"
+    "test-only": "mocha --timeout 1000000 -g",
+    "test": "c8 mocha -p -j 4 test --timeout 1100000"
   },
   "dependencies": {
     "@google-cloud/compute": "^4.0.0",

compute/test/createInstanceReplicatedBootDisk.test.js

@@ -19,7 +19,7 @@
 const path = require('path');
 const assert = require('node:assert/strict');
 const uuid = require('uuid');
-const {after, before, describe, it} = require('mocha');
+const {describe, it} = require('mocha');
 const cp = require('child_process');
 const computeLib = require('@google-cloud/compute');
 const {getStaleVMInstances, deleteInstance} = require('./util');
@@ -118,28 +118,15 @@ describe('Create compute instance with replicated boot disk', async () => {
   let projectId;
   let diskSnapshotLink;
 
-  before(async () => {
+  it('should create an instance with replicated boot disk', async () => {
+    // before
     const instancesClient = new computeLib.InstancesClient();
     projectId = await instancesClient.getProjectId();
     diskSnapshotLink = `projects/${projectId}/global/snapshots/${snapshotName}`;
 
     await createDisk(projectId, zone1, diskName);
     await createDiskSnapshot(projectId, zone1, diskName, snapshotName);
-  });
-
-  after(async () => {
-    // Cleanup resources
-    const instances = await getStaleVMInstances();
-    await Promise.all(
-      instances.map(instance =>
-        deleteInstance(instance.zone, instance.instanceName)
-      )
-    );
-    await deleteDiskSnapshot(projectId, snapshotName);
-    await deleteDisk(projectId, zone1, diskName);
-  });
 
-  it('should create an instance with replicated boot disk', () => {
     const response = execSync(
       `node ./instances/create-start-instance/createInstanceReplicatedBootDisk.js ${zone1} ${zone2} ${vmName} ${diskSnapshotLink}`,
       {
@@ -152,5 +139,15 @@ describe('Create compute instance with replicated boot disk', async () => {
         `Instance: ${vmName} with replicated boot disk created.`
       )
     );
+
+    // after Cleanup resources
+    await deleteDiskSnapshot(projectId, snapshotName);
+    await deleteDisk(projectId, zone1, diskName);
+    const instances = await getStaleVMInstances();
+    await Promise.all(
+      instances.map(instance =>
+        deleteInstance(instance.zone, instance.instanceName)
+      )
+    );
   });
 });

compute/test/replicatedDisk.test.js

@@ -19,7 +19,7 @@
 const path = require('path');
 const assert = require('node:assert/strict');
 const uuid = require('uuid');
-const {after, before, describe, it} = require('mocha');
+const {describe, it} = require('mocha');
 const cp = require('child_process');
 const computeLib = require('@google-cloud/compute');
 
@@ -57,31 +57,21 @@
   const zone2 = `${region}-b`;
   let projectId;
 
-  before(async () => {
+  it('should create a regional replicated disk and attach to vm', async () => {
     const instancesClient = new computeLib.InstancesClient();
     projectId = await instancesClient.getProjectId();
-  });
-
-  after(async () => {
-    // Cleanup resources
-    execSync(`node ./deleteInstance.js ${projectId} ${zone1} ${vmName}`, {
-      cwd,
-    });
-    await deleteDisk(projectId, region, diskName);
-  });
 
-  it('should create a regional replicated disk', () => {
     const response = execSync(
       `node ./disks/createRegionalReplicatedDisk.js ${diskName} ${region} ${zone1} ${zone2}`,
       {
         cwd,
       }
     );
 
+    console.log(`replicatedDisk.tests.js: Disk ${diskName} created.`);
+
     assert(response.includes(`Regional replicated disk: ${diskName} created.`));
-  });
 
-  it('should attach replicated disk to vm', () => {
     // Create VM, where replicated disk will be attached.
     execSync(
       `node ./createInstance.js ${projectId} ${zone1} ${vmName} e2-small`,
@@ -90,17 +80,27 @@
       }
     );
 
-    const response = execSync(
+    console.log(`replicatedDisk.tests.js: Instance ${vmName} created.`);
+
+    const responseAttach = execSync(
       `node ./disks/attachRegionalDisk.js ${diskName} ${region} ${vmName} ${zone1}`,
       {
         cwd,
       }
     );
 
+    console.log(`replicatedDisk.tests.js: Disk ${diskName} attached to ${vmName}.`);
+
     assert(
-      response.includes(
+      responseAttach.includes(
         `Replicated disk: ${diskName} attached to VM: ${vmName}.`
       )
     );
+
+    // Cleanup resources
+    execSync(`node ./deleteInstance.js ${projectId} ${zone1} ${vmName}`, {
+      cwd,
+    });
+    await deleteDisk(projectId, region, diskName);
   });
 });