Skip to content

Conversation

@davidcavazos
Copy link

@davidcavazos davidcavazos commented May 12, 2025

Description

Since these run from workflow_run, the default checkout branch is main, not the PR commit.

Explicitly reference the commit SHA from the workflow_run event (the PR).

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@davidcavazos davidcavazos marked this pull request as ready for review May 12, 2025 21:56
@davidcavazos davidcavazos requested review from a team as code owners May 12, 2025 21:56
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels May 12, 2025
@davidcavazos davidcavazos changed the title fix: checkout correct sha fix: checkout correct commit on workflow_run jobs May 12, 2025
@glasnt glasnt merged commit 0494bcb into main May 12, 2025
14 checks passed
@glasnt glasnt deleted the custard-checkout branch May 12, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants