Skip to content

fix(retail): add region tag for nodejs - Update remove fulfillment places #4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glasnt merged 13 commits into from
Jul 15, 2025
Merged

fix(retail): add region tag for nodejs - Update remove fulfillment places #4121

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bf9bdd0
Update search-simple-query.js
rebeccaellis Jun 10, 2025
4248f5c
Merge pull request #1 from rebeccaellis/rebeccaellis-patch-1
rebeccaellis Jun 10, 2025
79c293e
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 10, 2025
ec27aa3
Update search-with-pagination.js
rebeccaellis Jun 10, 2025
521dafa
Merge pull request #2 from rebeccaellis/rebeccaellis-patch-search-wit…
rebeccaellis Jun 11, 2025
bb3d2dc
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 12, 2025
d26b14b
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 17, 2025
d214b97
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 18, 2025
0516da1
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 27, 2025
d23b299
Update remove-fulfillment-places.js
rebeccaellis Jun 28, 2025
dca79a2
Merge branch 'main' into rebeccaellis-remove-fulfillment-places
glasnt Jul 2, 2025
a501632
Merge branch 'main' into rebeccaellis-remove-fulfillment-places
glasnt Jul 15, 2025
b292afd
Merge branch 'main' into rebeccaellis-remove-fulfillment-places
glasnt Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions retail/interactive-tutorials/product/remove-fulfillment-places.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

'use strict';

// [START retail_remove_fulfillment_places]
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The region tag name retail_remove_fulfillment_places suggests it covers only the logic for removing fulfillment places. However, the tag spans the entire script, including setup (product creation) and teardown (product deletion). This can be misleading.

To more accurately reflect that this tag covers the entire runnable tutorial, it's better to rename it.

Suggested change
// [START retail_remove_fulfillment_places]
// [START retail_remove_fulfillment_places_tutorial]


async function main(generatedProductId) {
// Imports the Google Cloud client library.
const {ProductServiceClient} = require('@google-cloud/retail').v2;
Expand Down Expand Up @@ -84,3 +86,5 @@ process.on('unhandledRejection', err => {
});

main(...process.argv.slice(2));

// [END retail_remove_fulfillment_places]
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the START tag, this END tag should also be renamed to match. This ensures the region tags are correctly paired and avoids errors.

Suggested change
// [END retail_remove_fulfillment_places]
// [END retail_remove_fulfillment_places_tutorial]

Loading