Skip to content

feat(genai): controlled generation #4148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Guiners
Copy link

@Guiners Guiners commented Aug 5, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@Guiners Guiners requested review from a team as code owners August 5, 2025 08:28
Copy link

snippet-bot bot commented Aug 5, 2025

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 5, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Guiners, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive set of new samples for the Google GenAI SDK, focusing on the 'controlled generation' feature. These additions provide clear examples of how to structure AI model responses using various schema definitions, enhancing the SDK's utility for developers. Alongside these new features, existing samples have been updated to leverage the latest gemini-2.5-flash model, and corresponding tests have been added or adjusted to maintain robust coverage.

Highlights

  • New Controlled Generation Samples: Added five new JavaScript samples demonstrating various ways to use controlled generation with the Google GenAI SDK. These samples showcase defining response schemas using JavaScript classes, enums, nested classes, nullable properties, and direct JSON schema objects.
  • Updated GenAI Models: Updated existing samples to use the generally available gemini-2.5-flash model, replacing gemini-2.0-flash and gemini-2.5-flash-preview-05-20.
  • New Test Coverage: Introduced dedicated test files for each of the new controlled generation samples to ensure their functionality and correctness.
  • Test Timeout Adjustment: Increased the timeout for the tools-code-exec-with-txt.test.js to accommodate potentially longer execution times for code generation and execution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new examples for controlled generation with GenAI. The feedback focuses on improving code consistency (using camelCase), ensuring robust schema definitions and tests, and correcting minor issues in the test setup.

@msampathkumar
Copy link
Member

Tagging @gericdong for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants