Skip to content

Conversation

@Guiners
Copy link
Contributor

@Guiners Guiners commented Nov 20, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@Guiners Guiners requested review from a team as code owners November 20, 2025 10:11
@snippet-bot
Copy link

snippet-bot bot commented Nov 20, 2025

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 20, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Guiners, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the GenAI sample collection by adding new examples that showcase advanced capabilities of the Google GenAI SDK. These additions cover key areas such as visual content analysis with bounding boxes, efficient information retrieval using embeddings, flexible authentication with API keys, optimized model deployment via provisioned throughput, and robust content moderation through configurable safety settings. The changes also include necessary updates to project dependencies to align with the latest SDK versions and best practices.

Highlights

  • New GenAI Samples: Introduces five new samples demonstrating various Google GenAI SDK features, including bounding box detection, document retrieval embeddings, API key authentication, provisioned throughput, and content safety settings.
  • Dependency Updates: The @google/genai dependency has been updated, and several other dependencies have been adjusted in genai/package.json to support the new samples and streamline the project.
  • Comprehensive Testing: Each new sample is accompanied by a dedicated test file, ensuring the functionality and correctness of the added features.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several new samples for the GenAI SDK. My review focuses on correctness, security best practices, and ensuring the samples are runnable and accurately demonstrate the intended features. I've found a critical issue in package.json where runtime dependencies are listed as dev dependencies, which will break the samples for users. I've also identified several high-severity issues, including a security concern with a hardcoded API key placeholder, misleading sample code, and incorrect error handling and testing for safety-blocked responses. Additionally, there are some medium-severity suggestions to improve code quality.

@Guiners Guiners changed the title feat(genai): rest of samples feat(genai): Add samples for Tools, Embeddings, Provisioned Throughput and Text-generation Nov 20, 2025
@Guiners Guiners changed the title feat(genai): Add samples for Tools, Embeddings, Provisioned Throughput and Text-generation feat(genai): Add samples for Bounding Box, Embeddings, Provisioned Throughput, Safety Nov 20, 2025
@cfloress
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants