-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(genai): Add samples for Bounding Box, Embeddings, Provisioned Throughput, Safety #4196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @Guiners, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the GenAI sample collection by adding new examples that showcase advanced capabilities of the Google GenAI SDK. These additions cover key areas such as visual content analysis with bounding boxes, efficient information retrieval using embeddings, flexible authentication with API keys, optimized model deployment via provisioned throughput, and robust content moderation through configurable safety settings. The changes also include necessary updates to project dependencies to align with the latest SDK versions and best practices. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds several new samples for the GenAI SDK. My review focuses on correctness, security best practices, and ensuring the samples are runnable and accurately demonstrate the intended features. I've found a critical issue in package.json where runtime dependencies are listed as dev dependencies, which will break the samples for users. I've also identified several high-severity issues, including a security concern with a hardcoded API key placeholder, misleading sample code, and incorrect error handling and testing for safety-blocked responses. Additionally, there are some medium-severity suggestions to improve code quality.
|
LGTM |
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.