Skip to content

Conversation

@Guiners
Copy link
Contributor

@Guiners Guiners commented Dec 5, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@Guiners Guiners requested review from a team as code owners December 5, 2025 09:56
@snippet-bot
Copy link

snippet-bot bot commented Dec 5, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 5, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Guiners, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Generative AI samples by adding new functionalities for token counting. It provides developers with practical examples of how to use the Google Generative AI SDK to either retrieve a detailed breakdown of tokens or simply get the total token count for a given text input. These additions are crucial for understanding and managing the token usage of AI models.

Highlights

  • New Token Counting Samples: Introduced two new Node.js samples demonstrating how to count tokens using the Google Generative AI SDK for text prompts.
  • Detailed Token Information: One sample, counttoken-localtokenizer-compute-with-txt.js, showcases the client.models.computeTokens method, which provides detailed information about the tokens in a given text input, including token IDs and the tokens themselves.
  • Total Token Count: Another sample, counttoken-localtokenizer-with-txt.js, demonstrates the client.models.countTokens method, which returns the total number of tokens for a text prompt.
  • Unit Tests Added: Corresponding unit tests have been added for both new token counting samples to ensure their correct functionality and output.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two new samples for counting tokens with genai, along with their tests. The changes look good, but I have a few suggestions to improve consistency, correctness, and robustness.

My main feedback points are:

  • Adopting camelCase for function names for consistency.
  • Modifying sample functions to accept project and location parameters, which is a common pattern in this repository and makes them more testable.
  • Adding validation for the projectId.
  • Correcting a misleading test description and an example output comment.

I've left detailed comments with code suggestions for each point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant