-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(genai): Adding count token samples #4200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @Guiners, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Generative AI samples by adding new functionalities for token counting. It provides developers with practical examples of how to use the Google Generative AI SDK to either retrieve a detailed breakdown of tokens or simply get the total token count for a given text input. These additions are crucial for understanding and managing the token usage of AI models. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two new samples for counting tokens with genai, along with their tests. The changes look good, but I have a few suggestions to improve consistency, correctness, and robustness.
My main feedback points are:
- Adopting camelCase for function names for consistency.
- Modifying sample functions to accept
projectandlocationparameters, which is a common pattern in this repository and makes them more testable. - Adding validation for the
projectId. - Correcting a misleading test description and an example output comment.
I've left detailed comments with code suggestions for each point.
genai/count-tokens/counttoken-localtokenizer-compute-with-txt.js
Outdated
Show resolved
Hide resolved
genai/count-tokens/counttoken-localtokenizer-compute-with-txt.js
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.