Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions appengine/storage/flexible/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ Before you can run or deploy the sample, you will need to do the following:
1. Create a Cloud Storage Bucket. You can do this with the [Google Cloud SDK](https://cloud.google.com/sdk)
with the following command:

gsutil mb gs://<your-bucket-name>
gcloud storage buckets create gs://<your-bucket-name>

1. Set the default ACL on your bucket to public read in order to serve files
directly from Cloud Storage. You can do this with the [Google Cloud SDK](https://cloud.google.com/sdk)
with the following command:

gsutil defacl set public-read gs://<your-bucket-name>
gcloud storage buckets update gs://<your-bucket-name> --predefined-default-object-acl=public-read

1. Update the environment variables in `app.yaml`.

Expand Down
4 changes: 2 additions & 2 deletions appengine/storage/flexible_nodejs16_and_earlier/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ Before you can run or deploy the sample, you will need to do the following:
1. Create a Cloud Storage Bucket. You can do this with the [Google Cloud SDK](https://cloud.google.com/sdk)
with the following command:

gsutil mb gs://<your-bucket-name>
gcloud storage buckets create gs://<your-bucket-name>

1. Set the default ACL on your bucket to public read in order to serve files
directly from Cloud Storage. You can do this with the [Google Cloud SDK](https://cloud.google.com/sdk)
with the following command:

gsutil defacl set public-read gs://<your-bucket-name>
gcloud storage buckets update gs://<your-bucket-name> --predefined-default-object-acl=public-read

1. Update the environment variables in `app.yaml`.

Expand Down
4 changes: 2 additions & 2 deletions appengine/storage/standard/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ Before you can run or deploy the sample, you will need to do the following:
1. Create a Cloud Storage Bucket. You can do this with the [Google Cloud SDK](https://cloud.google.com/sdk)
with the following command:

gsutil mb gs://<your-bucket-name>
gcloud storage buckets create gs://<your-bucket-name>

1. Set the default ACL on your bucket to public read in order to serve files
directly from Cloud Storage. You can do this with the [Google Cloud SDK](https://cloud.google.com/sdk)
with the following command:

gsutil defacl set public-read gs://<your-bucket-name>
gcloud storage buckets update --predefined-default-object-acl=public-read gs://<your-bucket-name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the other updated README.md files in this PR and general gcloud command-line syntax conventions, it's better to place the positional argument (gs://<your-bucket-name>) before the flags.

Suggested change
gcloud storage buckets update --predefined-default-object-acl=public-read gs://<your-bucket-name>
gcloud storage buckets update gs://<your-bucket-name> --predefined-default-object-acl=public-read


1. Update the environment variables in `app.yaml`.

Expand Down
Loading