Cleanup the resource detector code a bit #389
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to releasing.md.
Delete the old deprecated resource detector in __init__.py, and replace it with the new resource detector from _detector.py. Add an entry point to setup.cfg so that the GCP resource detector works with auto instrumentation.
|
👍 , that auto-instrumentation looks good to me |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code examples for how to use the GoogleCloudResourceDetector.
Delete the old deprecated resource detector in init.py, and replace
it with the new resource detector from _detector.py.
Add an entry point to setup.cfg so that the GCP resource detector works with
auto instrumentation.