Skip to content

Conversation

@tgwizard
Copy link
Contributor

Fix for #357. Based on the Go / TS implementations, https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/d6795b491c748855e4a4d6eec07ae2cb44a78da1/exporter/metric/metric.go#L723.

I've tested this on a small app, and it seems to work fine.

@tgwizard tgwizard requested a review from a team as a code owner June 23, 2025 13:12
@google-cla
Copy link

google-cla bot commented Jun 23, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dashpole
Copy link
Contributor

/gcbrun

@tgwizard
Copy link
Contributor Author

@dashpole I see the linting errors (I had a hard time getting my IDE to respect the settings). I've now pushed a fix manually.

@dashpole
Copy link
Contributor

/gcbrun

@tgwizard
Copy link
Contributor Author

@dashpole most of CI seems to pass, I'm not sure how to parse the e2e test failures, if they are related to this PR.

@tgwizard
Copy link
Contributor Author

tgwizard commented Jul 1, 2025

Gentle bump on this @dashpole @aabmass

@dashpole dashpole requested a review from DylanRussell July 1, 2025 13:35
Copy link
Collaborator

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please just address @DylanRussell's comment

@aabmass
Copy link
Collaborator

aabmass commented Jul 10, 2025

Thank you for the PR!

@tgwizard
Copy link
Contributor Author

Fix pushed, thank you @DylanRussell @aabmass

@DylanRussell DylanRussell enabled auto-merge (squash) July 11, 2025 13:30
@DylanRussell
Copy link
Contributor

/gcbrun

@DylanRussell DylanRussell merged commit a97a85b into GoogleCloudPlatform:main Jul 11, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants