-
Notifications
You must be signed in to change notification settings - Fork 45
Add support for exponential histograms #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for exponential histograms #413
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
/gcbrun |
|
@dashpole I see the linting errors (I had a hard time getting my IDE to respect the settings). I've now pushed a fix manually. |
|
/gcbrun |
|
@dashpole most of CI seems to pass, I'm not sure how to parse the e2e test failures, if they are related to this PR. |
opentelemetry-exporter-gcp-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Outdated
Show resolved
Hide resolved
aabmass
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please just address @DylanRussell's comment
|
Thank you for the PR! |
|
Fix pushed, thank you @DylanRussell @aabmass |
|
/gcbrun |
Fix for #357. Based on the Go / TS implementations, https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/d6795b491c748855e4a4d6eec07ae2cb44a78da1/exporter/metric/metric.go#L723.
I've tested this on a small app, and it seems to work fine.