Skip to content

Conversation

@eapl-gemugami
Copy link
Contributor

@eapl-gemugami eapl-gemugami commented Mar 26, 2025

Description

Fixes Internal: b/393632125

  • Update google/cloud-document-ai to the latest version 2.1.3
  • Refactor sample to comply with new syntax requested by the client library
  • Migrate phpunit XML definition to v9.3, as requested when running the test

Checklist

  • I have followed guidelines from the CONTRIBUTING.MD
  • Appropriate changes to README are included in PR
  • Test passed: ../testing/vendor/bin/phpunit test/ -v
  • Lint passed: php-cs-fixer fix . --config .php-cs-fixer.dist.php
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: documentai Issues related to the Document AI API. samples Issues that are directly related to samples. labels Mar 26, 2025
<env name="PHPUNIT_TESTS" value="1"/>
</php>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="../testing/bootstrap.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
<coverage>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I don't think any of these changes in phpunit.xml are needed... we don't care about code coverage for samples.

@bshaffer bshaffer marked this pull request as ready for review April 9, 2025 16:51
@bshaffer bshaffer requested a review from a team as a code owner April 9, 2025 16:51
@bshaffer bshaffer merged commit dbf6d80 into GoogleCloudPlatform:main Apr 9, 2025
4 of 11 checks passed
@eapl-gemugami eapl-gemugami deleted the paradalicea/fix/documentai/quickstart-sample/b-393632125 branch April 9, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: documentai Issues related to the Document AI API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants