-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(deps): update dependency google/cloud-spanner to v2 - autoclosed #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency google/cloud-spanner to v2 - autoclosed #2169
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the google/cloud-spanner dependency to version 2. This is a major version upgrade which may introduce breaking changes. My review highlights the risk of breakage due to the lack of corresponding code changes in the samples and the absence of a detailed migration guide in the release notes. Thorough testing is needed to ensure compatibility before merging.
| { | ||
| "require": { | ||
| "google/cloud-spanner": "^1.97" | ||
| "google/cloud-spanner": "^2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR updates google/cloud-spanner to v2, a new major version. Major versions often introduce breaking changes. Since there are no corresponding updates in the sample code to adapt to a new API, there is a high risk of the samples breaking. The v2 release notes lack a migration guide, which makes it difficult to assess the impact without running the full test suite.
This PR contains the following updates:
^1.97->^2.0Release Notes
googleapis/google-cloud-php-spanner (google/cloud-spanner)
v2.1.0: google/cloud-spanner v2.1.0Compare Source
Features
v2.0.0: google/cloud-spanner v2.0.0Compare Source
Miscellaneous Chores
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.