Skip to content

refactor: (GenAI) Reorganized Model Garden Samples (Group B) #12599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

refactor: (GenAI) Reorganized Model Garden Samples (Group B) #12599

merged 1 commit into from
Sep 23, 2024

Conversation

Thoughtseize1
Copy link
Contributor

@Thoughtseize1 Thoughtseize1 commented Sep 17, 2024 •
edited
Loading

Description

Created new folder: /generative_ai/model_garden

Region_tag New file
generativeaionvertexai_claude_3_streaming model_garden/claude_3_streaming_example.py
generativeaionvertexai_claude_3_tool_use model_garden/claude_3_tool_example.py
generativeaionvertexai_claude_3_unary model_garden/claude_3_unary_example.py

File with all tests: -> /model_garden/model_garden_test.py

❗Files need to be deleted after approval:

  • /generative_ai/anthropic_claude_3_streaming.py
  • /generative_ai/anthropic_claude_3_streaming_test.py
  • /generative_ai/anthropic_claude_3_tool_use.py
  • /generative_ai/anthropic_claude_3_tool_use_test.py
  • /generative_ai/anthropic_claude_3_unary.py
  • /generative_ai/anthropic_claude_3_unary_test.py

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 17, 2024
@Thoughtseize1 Thoughtseize1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 17, 2024
@Thoughtseize1 Thoughtseize1 added the snippet-bot:force-run Force snippet-bot runs its logic label Sep 18, 2024
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Sep 18, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Sep 18, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Thoughtseize1 Thoughtseize1 marked this pull request as ready for review September 18, 2024 09:31
@Thoughtseize1 Thoughtseize1 requested review from a team as code owners September 18, 2024 09:31
msampathkumar
msampathkumar approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msampathkumar msampathkumar merged commit ea03651 into main Sep 23, 2024
14 checks passed
@msampathkumar msampathkumar deleted the Reorganize-GenAI-Samples-Model-Garden branch September 23, 2024 17:10
@Thoughtseize1 Thoughtseize1 mentioned this pull request Oct 2, 2024
Merged
9 tasks
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
@Thoughtseize1 @riathakkar
refactor: (GenAI) Reorganized Model Garden Samples (Group B) (GoogleC…
7233f32 
…loudPlatform#12599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msampathkumar msampathkumar msampathkumar approved these changes

Assignees

@msampathkumar msampathkumar

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thoughtseize1 @msampathkumar @kokoro-team