Skip to content

refactor(generative-ai): Cleaning old samples - Group B -> Grounding, Image Geneneration, Model Garden, Model Tuning #12669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

refactor(generative-ai): Cleaning old samples - Group B -> Grounding, Image Geneneration, Model Garden, Model Tuning #12669

merged 1 commit into from
Oct 3, 2024

Conversation

Thoughtseize1
Copy link
Contributor

@Thoughtseize1 Thoughtseize1 commented Oct 2, 2024 •
edited
Loading

Description

Cleaning Samples after refactoring Group B

Related PR's:

Feature Name PR Link
Grounding PR#12594
Image Generation PR#12595
Model Garden PR#12599
Model Tuning Calling PR#12605

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 2, 2024
@Thoughtseize1 Thoughtseize1 added the snippet-bot:force-run Force snippet-bot runs its logic label Oct 2, 2024
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 2, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Oct 2, 2024 •
edited by msampathkumar
Loading

Here is the summary of changes.

You are about to delete 31 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@msampathkumar msampathkumar self-assigned this Oct 2, 2024
@msampathkumar msampathkumar added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 2, 2024
@msampathkumar msampathkumar marked this pull request as ready for review October 3, 2024 11:14
@msampathkumar msampathkumar requested review from a team as code owners October 3, 2024 11:14
msampathkumar
msampathkumar approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approving only after I have manually verified cloud docs, for each region tags.

@msampathkumar msampathkumar removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 3, 2024
@msampathkumar msampathkumar merged commit 16e3610 into main Oct 3, 2024
15 checks passed
@msampathkumar msampathkumar deleted the Cleaning-Samples-Group-B branch October 3, 2024 11:17
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
@Thoughtseize1 @riathakkar
refactor(generative-ai): Cleaning old samples - Group B -> Grounding,…
1d54987 
… Image Geneneration, Model Garden, Model Tuning (GoogleCloudPlatform#12669)

For more details check go/runnable-snippets-execute & b/366463306

Migrating code samples into feature specific folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msampathkumar msampathkumar msampathkumar approved these changes

Assignees

@msampathkumar msampathkumar

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Thoughtseize1 @msampathkumar