Skip to content

feat: Update session sample with the new SessionServiceClient #13529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glasnt merged 2 commits into from
Aug 8, 2025
Merged

feat: Update session sample with the new SessionServiceClient #13529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0343b6f
feat: Update session sample with the new SessionServiceClient instead…
mostafaalaa3 Jul 31, 2025
114fce4
chore(deps): update google-cloud-discoveryengine to new version suppo…
glasnt Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion discoveryengine/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
google-cloud-discoveryengine==0.13.8
google-cloud-discoveryengine==0.13.11
10 changes: 5 additions & 5 deletions discoveryengine/session_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def create_session(
discoveryengine.Session: The newly created Session.
"""

client = discoveryengine.ConversationalSearchServiceClient()
client = discoveryengine.SessionServiceClient()
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instantiating a new client for each function call is not a recommended practice for production applications. Google Cloud client libraries are designed to have their client instances reused to avoid the overhead of setting up new connections for each request.

While this pattern is acceptable for a self-contained sample where each function is independent, adding a comment to educate users about this best practice would be very helpful.

This feedback also applies to the other functions in this file where a client is instantiated (lines 74, 107, 141, and 181).

Suggested change
client = discoveryengine.SessionServiceClient()
# In real-world applications, a single client instance should be created and reused for better performance.
client = discoveryengine.SessionServiceClient()


session = client.create_session(
# The full resource name of the engine
Expand Down Expand Up @@ -71,7 +71,7 @@ def get_session(
session_id: The ID of the session.
"""

client = discoveryengine.ConversationalSearchServiceClient()
client = discoveryengine.SessionServiceClient()

# The full resource name of the session
name = f"projects/{project_id}/locations/{location}/collections/default_collection/engines/{engine_id}/sessions/{session_id}"
Expand Down Expand Up @@ -104,7 +104,7 @@ def delete_session(
session_id: The ID of the session.
"""

client = discoveryengine.ConversationalSearchServiceClient()
client = discoveryengine.SessionServiceClient()

# The full resource name of the session
name = f"projects/{project_id}/locations/{location}/collections/default_collection/engines/{engine_id}/sessions/{session_id}"
Expand Down Expand Up @@ -138,7 +138,7 @@ def update_session(
Returns:
discoveryengine.Session: The updated Session.
"""
client = discoveryengine.ConversationalSearchServiceClient()
client = discoveryengine.SessionServiceClient()

# The full resource name of the session
name = f"projects/{project_id}/locations/{location}/collections/default_collection/engines/{engine_id}/sessions/{session_id}"
Expand Down Expand Up @@ -178,7 +178,7 @@ def list_sessions(
discoveryengine.ListSessionsResponse: The list of sessions.
"""

client = discoveryengine.ConversationalSearchServiceClient()
client = discoveryengine.SessionServiceClient()

# The full resource name of the engine
parent = f"projects/{project_id}/locations/{location}/collections/default_collection/engines/{engine_id}"
Expand Down