-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat: add Python 3.14 to samples testing image #13596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
417c600
to
3a2ae38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Python versions in the testing Docker image, adding support for Python 3.14 and refreshing patch versions for others. My feedback focuses on improving the readability and maintainability of the Dockerfile where these versions are listed.
.kokoro/docker/Dockerfile
Outdated
&& echo "disable-ipv6" >> "${GNUPGHOME}/dirmngr.conf" \ | ||
&& /tmp/fetch_gpg_keys.sh \ | ||
&& for PYTHON_VERSION in 2.7.18 3.7.17 3.8.20 3.9.20 3.10.15 3.11.10 3.12.7 3.13.0; do \ | ||
&& for PYTHON_VERSION in 2.7.18 3.7.17 3.8.20 3.9.23 3.10.18 3.11.13 3.12.11 3.13.8 3.14.0; do \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list of Python versions is getting long and hard to read on a single line. To improve readability and maintainability, I suggest extracting the versions into a shell variable. This makes the list much easier to manage for future updates.
&& PYTHON_VERSIONS="\
2.7.18 \
3.7.17 \
3.8.20 \
3.9.23 \
3.10.18 \
3.11.13 \
3.12.11 \
3.13.8 \
3.14.0" \
&& for PYTHON_VERSION in $PYTHON_VERSIONS; do \
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in d92eb95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion
.kokoro/docker/Dockerfile
Outdated
3.12.11 \ | ||
3.13.8 \ | ||
3.14.0" \ | ||
&& for PYTHON_VERSION in $PYTHON_VERSIONS; do \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to avoid variables that differ only by one letter. How about
for VERSION in $PYTHON_VERSIONS
or for PYTHON_VERSION in $ALL_PYTHON_VERSIONS
?
Similar to #12780