-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat: add code samples for preference tuning #13644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add code samples for preference tuning #13644
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @kuirensu-crypto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new code sample for Preference Tuning within the Google GenAI SDK. This is crucial for users looking to leverage Vertex Tuning's advanced optimization methods for generative AI models, specifically demonstrating how to fine-tune models like Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new code sample for preference tuning. The overall structure is good, but there are several areas for improvement. Most importantly, the new sample is missing tests, which are crucial for ensuring correctness and preventing future regressions. I've also suggested refactoring the code to accept parameters instead of using hardcoded values, which will improve reusability and make it easier for users to run the sample. Additionally, I've pointed out a potential issue with the API version being used and offered some minor suggestions for improving code style and maintainability.
e1ff4fc to
58c2129
Compare
Description
Preference Optimization is a new tuning method offered by Vertex Tuning.
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)