Skip to content

Commit 35d0ad9

Browse files
author
Frank Natividad
committed
Enabling skipped test in logging spec
1 parent ade422e commit 35d0ad9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

logging/spec/sample_spec.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,7 @@ def cleanup!
153153
).to_stdout
154154
end
155155

156-
# XXX This test is flaky so it is currently disabled
157-
# Will send future pull request to re-enable when fixed
158-
skip "can write log entry" do
156+
it "can write log entry" do
159157
current_time = Time.now.to_f
160158

161159
# Log entries refer to a particular resource
@@ -184,13 +182,15 @@ def cleanup!
184182
write_log_entry
185183

186184
# Wait for entry to be queryable
185+
entries = []
186+
187187
wait_until do
188-
my_application_log_entries.any? do |e|
188+
entries = my_application_log_entries
189+
entries.any? do |e|
189190
e.payload == "Log message - current time #{current_time}"
190191
end
191192
end
192193

193-
entries = my_application_log_entries
194194
entry = entries.detect { |e| e.payload.include? "time #{current_time}" }
195195
expect(entry).not_to be nil
196196
expect(entry.payload).to eq "Log message - current time #{current_time}"

0 commit comments

Comments
 (0)