Skip to content

Fixing varbinary (varbinary(XX)) schema migration for mysql to map to correct spanner type with length BYTES(XX)#1164

Merged
darshan-sj merged 3 commits intomasterfrom
binary-len-fix
Jul 20, 2025
Merged

Fixing varbinary (varbinary(XX)) schema migration for mysql to map to correct spanner type with length BYTES(XX)#1164
darshan-sj merged 3 commits intomasterfrom
binary-len-fix

Conversation

@darshan-sj
Copy link
Contributor

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@darshan-sj darshan-sj requested a review from a team as a code owner July 18, 2025 06:51
@darshan-sj darshan-sj requested review from Deep1998 and shreyakhajanchi and removed request for a team July 18, 2025 06:51
Copy link
Contributor

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure the github actions pass before merging

@codecov
Copy link

codecov bot commented Jul 20, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.66%. Comparing base (1af53bd) to head (c7d027f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sources/mysql/toddl.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1164      +/-   ##
==========================================
+ Coverage   43.64%   43.66%   +0.01%     
==========================================
  Files         227      227              
  Lines       26228    26236       +8     
  Branches      575      575              
==========================================
+ Hits        11448    11455       +7     
- Misses      14048    14049       +1     
  Partials      732      732              
Components Coverage Δ
backend-apis 44.51% <ø> (ø)
backend-library 46.26% <66.66%> (+<0.01%) ⬆️
cli 22.40% <ø> (ø)
frontend 36.24% <ø> (+0.05%) ⬆️
Files with missing lines Coverage Δ
sources/mysql/toddl.go 91.82% <66.66%> (-1.56%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@darshan-sj darshan-sj merged commit 43873cc into master Jul 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants