Skip to content

Fixing binary schema migration for mysql to map to correct spanner type with length BYTES(XX)#1166

Merged
darshan-sj merged 1 commit intomasterfrom
binary-len-fix
Jul 21, 2025
Merged

Fixing binary schema migration for mysql to map to correct spanner type with length BYTES(XX)#1166
darshan-sj merged 1 commit intomasterfrom
binary-len-fix

Conversation

@darshan-sj
Copy link
Contributor

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@darshan-sj darshan-sj requested a review from a team as a code owner July 21, 2025 10:30
@darshan-sj darshan-sj requested review from VardhanThigle and pratickchokhani and removed request for a team July 21, 2025 10:30
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.64%. Comparing base (6049111) to head (885e34a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1166      +/-   ##
==========================================
- Coverage   43.65%   43.64%   -0.01%     
==========================================
  Files         227      227              
  Lines       26236    26230       -6     
  Branches      575      575              
==========================================
- Hits        11453    11449       -4     
+ Misses      14051    14049       -2     
  Partials      732      732              
Components Coverage Δ
backend-apis 44.51% <ø> (ø)
backend-library 46.25% <100.00%> (-0.01%) ⬇️
cli 22.40% <ø> (ø)
frontend 36.19% <ø> (ø)
Files with missing lines Coverage Δ
sources/mysql/toddl.go 92.81% <100.00%> (+0.98%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@darshan-sj darshan-sj merged commit 45e64f7 into master Jul 21, 2025
15 checks passed
@darshan-sj darshan-sj deleted the binary-len-fix branch July 21, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants