Skip to content

Adding performance schema collector for query assessments#1168

Merged
shreyakhajanchi merged 5 commits intomasterfrom
query-assessment-2-pr
Aug 4, 2025
Merged

Adding performance schema collector for query assessments#1168
shreyakhajanchi merged 5 commits intomasterfrom
query-assessment-2-pr

Conversation

@shreyakhajanchi
Copy link
Contributor

No description provided.

@shreyakhajanchi shreyakhajanchi requested a review from a team as a code owner July 28, 2025 07:42
@shreyakhajanchi shreyakhajanchi requested review from Deep1998 and darshan-sj and removed request for a team July 28, 2025 07:42
@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 74.73684% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.73%. Comparing base (dce2c5b) to head (7f37e05).

Files with missing lines Patch % Lines
assessment/collectors/common/db_connector.go 0.00% 13 Missing ⚠️
assessment/assessment_engine.go 0.00% 8 Missing ⚠️
...essment/collectors/performance_schema_collector.go 93.93% 2 Missing ⚠️
assessment/collectors/infoschema_collector.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1168      +/-   ##
==========================================
+ Coverage   43.62%   43.73%   +0.11%     
==========================================
  Files         228      231       +3     
  Lines       26310    26396      +86     
  Branches      575      575              
==========================================
+ Hits        11477    11545      +68     
- Misses      14096    14114      +18     
  Partials      737      737              
Components Coverage Δ
backend-apis 44.51% <ø> (ø)
backend-library 46.37% <74.73%> (+0.18%) ⬆️
cli 22.40% <ø> (ø)
frontend 36.19% <ø> (-0.06%) ⬇️
Files with missing lines Coverage Δ
assessment/sources/mysql/performance_schema.go 100.00% <100.00%> (ø)
assessment/collectors/infoschema_collector.go 93.77% <50.00%> (+2.34%) ⬆️
...essment/collectors/performance_schema_collector.go 93.93% <93.93%> (ø)
assessment/assessment_engine.go 0.00% <0.00%> (ø)
assessment/collectors/common/db_connector.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shreyakhajanchi shreyakhajanchi changed the title Adding performance collector for query assessments Adding performance schema collector for query assessments Jul 28, 2025
Copy link
Contributor

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyakhajanchi shreyakhajanchi merged commit 109bcd2 into master Aug 4, 2025
9 checks passed
pratickchokhani pushed a commit to pratickchokhani/spanner-migration-tool that referenced this pull request Aug 12, 2025
…dPlatform#1168)

* Adding performance collector for query assessments

* addressing comments

* addressing comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants