Skip to content

Fixing primary key sort order for source#1170

Merged
shreyakhajanchi merged 4 commits intomasterfrom
pk-order-key
Aug 4, 2025
Merged

Fixing primary key sort order for source#1170
shreyakhajanchi merged 4 commits intomasterfrom
pk-order-key

Conversation

@shreyakhajanchi
Copy link
Contributor

image

@shreyakhajanchi shreyakhajanchi requested a review from a team as a code owner July 30, 2025 15:27
@shreyakhajanchi shreyakhajanchi requested review from darshan-sj and manitgupta and removed request for a team July 30, 2025 15:27
@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.60%. Comparing base (dce2c5b) to head (f4618d5).

Files with missing lines Patch % Lines
...omponents/object-detail/object-detail.component.ts 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
- Coverage   43.62%   43.60%   -0.02%     
==========================================
  Files         228      228              
  Lines       26310    26316       +6     
  Branches      575      575              
==========================================
- Hits        11477    11475       -2     
- Misses      14096    14104       +8     
  Partials      737      737              
Components Coverage Δ
backend-apis 44.51% <ø> (ø)
backend-library 46.19% <ø> (ø)
cli 22.40% <ø> (ø)
frontend 36.13% <0.00%> (-0.11%) ⬇️
Files with missing lines Coverage Δ
...omponents/object-detail/object-detail.component.ts 21.53% <0.00%> (-0.17%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyakhajanchi shreyakhajanchi merged commit 5f2c128 into master Aug 4, 2025
9 checks passed
pratickchokhani pushed a commit to pratickchokhani/spanner-migration-tool that referenced this pull request Aug 12, 2025
* Fixing primary key sort order for source

* addressing comments

* removing console log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants