UI changes for check constraint support by taherkl · Pull Request #979 · GoogleCloudPlatform/spanner-migration-tool

taherkl · 2024-12-30T10:10:31Z

Users can view details of check constraints in the Check Constraint tab.
Users will be able to add, delete, and edit check constraints.
Deletion of a column is restricted if it is used in a check constraint.
Validation is performed to prevent adding duplicate expressions or constraint names in check constraints.
Check constraints have been incorporated into the Spanner DDL query.
Integration with Verify Expression API

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

Tests pass
Appropriate changes to README are included in PR

asthamohta · 2025-01-01T16:41:23Z

Please checkout package json file

ui/src/app/components/object-detail/object-detail.component.ts

* remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com>

ui/package-lock.json

ui/dist/ui/main.1cfa12bd9a851a7a.js

taherkl · 2025-01-06T12:24:57Z

Hello @asthamohta Can you please merge the PR if everything looks good?

* verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com>

* feat: default values final PR (GoogleCloudPlatform#976) * changes * changes * changes * changes * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> * fixed if condition --------- Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) * UI changes for check constraint support (GoogleCloudPlatform#979) * UI changes for check constraint support * removed url changed for testing * Check UI cmt (#29) * remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> * updated the dist file and package.lock file * Develop (#36) * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: Astha Mohta <35952883+asthamohta@users.noreply.github.com> Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Manit Gupta <manitgupta@google.com>

* Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) * UI changes for check constraint support (GoogleCloudPlatform#979) * UI changes for check constraint support * removed url changed for testing * Check UI cmt (#29) * remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> * updated the dist file and package.lock file * Develop (#36) * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: Manit Gupta <manitgupta@google.com> Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com>

* verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <manitgupta@google.com> * sync upstream/master (#42) * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) * UI changes for check constraint support (GoogleCloudPlatform#979) * UI changes for check constraint support * removed url changed for testing * Check UI cmt (#29) * remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> * updated the dist file and package.lock file * Develop (#36) * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: Manit Gupta <manitgupta@google.com> Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Manit Gupta <manitgupta@google.com>

* verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> * Replace ReadOnlyTransaction() with Single() (#984) (#35) Co-authored-by: Manit Gupta <manitgupta@google.com> * sync upstream/master (#42) * Replace ReadOnlyTransaction() with Single() (#984) * UI changes for check constraint support (#979) * UI changes for check constraint support * removed url changed for testing * Check UI cmt (#29) * remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> * updated the dist file and package.lock file * Develop (#36) * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> * Replace ReadOnlyTransaction() with Single() (#984) (#35) Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: Manit Gupta <manitgupta@google.com> Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> * added updated build file --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com>

* verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <manitgupta@google.com> * sync upstream/master (#42) * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) * UI changes for check constraint support (GoogleCloudPlatform#979) * UI changes for check constraint support * removed url changed for testing * Check UI cmt (#29) * remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> * updated the dist file and package.lock file * Develop (#36) * verification API and dump flow changes to support MySQL CHECK CONSTRAINTS (GoogleCloudPlatform#978) (#30) * verification ap and dump flow changes * fixed IT issue * Check constraints verificartion api v2 (#24) * handled function not found * added unhandled error * updated the error msg --------- * fix IT issue * comment addressed (#27) * comment addressed 1. rename the functionNotFound 2. added condition to call verification api * spell checked --------- * refactor the DbDumpImpl struct (#28) * refactor the DbDumpImpl struct * remove the GenerateCheckConstrainstExprId method --------- * fixed if condition --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> * Replace ReadOnlyTransaction() with Single() (GoogleCloudPlatform#984) (#35) Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com> --------- Co-authored-by: Manit Gupta <manitgupta@google.com> Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> * updated the build and resolve the issue 1. verify api issue 2. drop column issue 3. updated the build * updated the build --------- Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: Akash Thawait <aakash@ollion.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: Manit Gupta <manitgupta@google.com>

UI changes for check constraint support

14377a2

pull-request-size bot added the size/XXL label Dec 30, 2024

removed url changed for testing

5d26fcd

asthamohta reviewed Jan 1, 2025

View reviewed changes

ui/src/app/components/object-detail/object-detail.component.ts Outdated Show resolved Hide resolved

asthamohta reviewed Jan 1, 2025

View reviewed changes

ui/src/app/components/object-detail/object-detail.component.ts Show resolved Hide resolved

akashthawaitcc and others added 3 commits January 2, 2025 11:37

Merge branch 'master' into check_constraints_ui

fd262f6

Merge branch 'master' into check_constraints_ui

aa3dce4

Check UI cmt (#29)

203275d

* remove the block which will not execute * refactor the code 1. remove the unreachable code 2. remvoe the node-sql-parser package * refactor the code 1. rename the generateId method --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com>

taherkl marked this pull request as ready for review January 3, 2025 04:49

taherkl requested a review from a team as a code owner January 3, 2025 04:49

taherkl requested review from Deep1998 and darshan-sj and removed request for a team January 3, 2025 04:49

shreyakhajanchi reviewed Jan 3, 2025

View reviewed changes

ui/package-lock.json Show resolved Hide resolved

ui/dist/ui/main.1cfa12bd9a851a7a.js Outdated Show resolved Hide resolved

updated the dist file and package.lock file

579db29

asthamohta approved these changes Jan 6, 2025

View reviewed changes

akashthawaitcc and others added 2 commits January 7, 2025 15:51

Merge branch 'master' into check_constraints_ui

41b4820

asthamohta merged commit 6892b44 into GoogleCloudPlatform:master Jan 7, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI changes for check constraint support#979

UI changes for check constraint support#979
asthamohta merged 8 commits intoGoogleCloudPlatform:masterfrom
ollionorg:check_constraints_ui

taherkl commented Dec 30, 2024 •

edited

Loading

Uh oh!

asthamohta commented Jan 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

taherkl commented Jan 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

taherkl commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asthamohta commented Jan 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

taherkl commented Jan 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

taherkl commented Dec 30, 2024 •

edited

Loading