Fix Flaky Test ConverterAwareMappingSpannerEntityReaderTests.readUnmatachableTypesTest()
#4187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a flaky test
readUnmatachableTypesTestinspring-cloud-gcp-data-spanner/src/test/java/com/google/cloud/spring/data/spanner/core/convert/ConverterAwareMappingSpannerEntityReaderTests.java.The original test asserted an exact exception message:
However, the order in which entity fields are processed is non-deterministic (due to reflection order).
As a result, the first failing field—and thus the message suffix—can vary between runs, leading to intermittent test failures.
Root Cause
SpannerEntityReaderuses reflection over entity fields, which does not guarantee order.Fix
The test has been updated to:
: id.Additional
There is a typo from the original test name, which is not modified due to consistency.