Skip to content

Conversation

@mehdi0933
Copy link

Description

This PR addresses the need for Spring Boot 4.0 compatibility within the Secret Manager module and adds a security feature for data sanitization in Actuator endpoints.

Changes

  • Sanitization: Added SecretManagerSanitizingFunction to mask values starting with sm:// in Actuator endpoints, preventing sensitive reference leaks.
  • Spring Boot 4.0 Support:
    • Moved autoconfiguration registration from spring.factories to the new modular structure: META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports.
    • Updated directory structure to comply with Spring Boot 3.x/4.x best practices.

Fixes #4183

@mehdi0933 mehdi0933 requested a review from a team as a code owner January 5, 2026 15:20
@mehdi0933 mehdi0933 changed the title Feat/spring boot 4 support secretmanager feat/spring boot 4 support secretmanager Jan 5, 2026
@mehdi0933 mehdi0933 changed the title feat/spring boot 4 support secretmanager feat:spring boot 4 support secretmanager Jan 5, 2026
@mehdi0933 mehdi0933 changed the title feat:spring boot 4 support secretmanager feat: spring boot 4 support secretmanager Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like the right content for the imports file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bushwakko, thanks for the catch! You're right. I might have kept the old spring.factories format by mistake. I will update the .imports file to ensure it only contains the fully qualified class names, one per line, as required by the new Spring Boot autoconfiguration registration. I'll push a fix shortly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bushwakko, I have updated the autoconfiguration imports to use the correct format (FQN, one per line) and removed the old spring.factories content.

I also took the opportunity to:

Fix all Checkstyle violations using google-java-format.

Refactor Spanner lifecycle events to use wildcard generics (Iterable<?>) for full Spring Framework 7 compatibility.

All local validations are passing. Ready for your review!

@mehdi0933 mehdi0933 force-pushed the feat/spring-boot-4-support-secretmanager branch from 017e353 to 5e56fb4 Compare January 6, 2026 14:18
@mehdi0933 mehdi0933 force-pushed the feat/spring-boot-4-support-secretmanager branch 2 times, most recently from 59b0775 to 5e56fb4 Compare January 6, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Spring Boot 4.0

2 participants