fix: resolve nondeterministic Spanner tests by improving SQL assertions#4278
Open
mehdi0933 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
fix: resolve nondeterministic Spanner tests by improving SQL assertions#4278mehdi0933 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
mehdi0933 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the flaky behavior in SpannerSchemaUtilsTests.java. The getCreateDdlTest was failing intermittently because it relied on a strict string comparison of the generated SQL CREATE TABLE statement.
The Problem: Java's reflection API does not guarantee the order in which fields are retrieved from a class. Consequently, the columns in the generated DDL string would occasionally swap positions, causing the test to fail despite the SQL being functionally correct.
The Solution: I replaced the strict isEqualTo(String) assertion with a set of robust assertions using AssertJ:
Verified the CREATE TABLE header and table name using startsWith.
Verified the PRIMARY KEY clause using contains.
Verified the presence of every individual column and its specific type/options using individual contains assertions.
Why this approach?
CI Stability: It eliminates "false negative" build failures caused by environment-specific field ordering.
Accuracy: It focuses on the technical contract (schema completeness) rather than cosmetic details (column order), which Spanner does not require to be in a specific sequence for table creation.
Low Impact: It avoids adding unnecessary sorting logic to the production code (SpannerSchemaUtils.java), keeping the framework's core logic lean.
See
also CONTRIBUTING.md
.