This repository was archived by the owner on Jan 6, 2023. It is now read-only.
Fix assert in model.py #5
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug when testing on a small dataset it fails when the number of items in the dataset is 3, the number of users is 10, the user rated 2, and I try to get 2 recommendations.
The assert is supposed to check that the number of items in the dataset is greater than the number of requested recommendations plus the number of items a user already rated. The reason I changed
row_factorwithcol_factoriscol_factor.shape[0]is the number of items in the dataset.