feat: Adding Submodule for Standalone Workflow for ADC #54

anshukaira · 2025-10-16T07:31:56Z

Created a standalone workflow sub module for Cloud Workflows, as the root required workflow_trigger, which essentially created either pub/sub or cloud scheduler job resources as well. The simple workflows aims to create standalone workflow as per now.

PR includes

Simple_workflows modules
Simple_workflow examples
Metadata display YAML file
Added validations for the required inputs

anshukaira · 2025-10-16T07:34:43Z

@bharathkkb @anaik91 @q2w

Requesting to review this PR.

- Added Submodule for Standalone workflow - Added Validations and metadata.display.yaml file for making submodule ADC compliant - Added relevant examples and test

anshukaira · 2025-10-21T07:12:13Z

/gcbrun

krprabhat-eng · 2025-10-22T06:22:52Z

modules/simple_workflow/variables.tf

+  type        = string
+}
+
+variable "workflow_description" {


I think it should be marked as level 1 as it doesn't seem an advanced field.

krprabhat-eng · 2025-10-22T06:23:30Z

modules/simple_workflow/variables.tf

+variable "workflow_description" {
+  description = "Description for the cloud workflow"
+  type        = string
+  default     = "Sample workflow Description"


Update the default value to null.

krprabhat-eng · 2025-10-22T06:26:23Z

modules/simple_workflow/variables.tf

+variable "service_account_email" {
+  description = "Service account email. Unused if service account is auto-created."
+  type        = string
+  default     = null
+}
+
+variable "service_account_create" {
+  description = "Auto-create service account."
+  type        = bool
+  default     = false
+}


I think one of this at least should be a level1 field.

Removed service account create option itself, we will be using the SA component in ADC itself

krprabhat-eng · 2025-10-22T06:29:38Z

examples/simple_workflow/main.tf

+  workflow_name         = "standalone-workflow"
+  region                = "us-central1"
+  service_account_email = module.service_account.email
+  service_account_create = true


I think this test/example should be renamed to something like with_service_account_auto_create and we should add more test to cover other scenarios related to service_account input.
Tests can be added later also.

as we have removed autocreate SA logic, this will be not required

krprabhat-eng · 2025-10-22T06:30:40Z

modules/simple_workflow/metadata.display.yaml

+      dir: /modules/simple-workflow
+  ui:
+    input:
+      variables:


Please check if we want to mark any optional input as level 1 if we want to show it along the required values in the ADC UI.

added optional input as level1

modules/simple_workflow/main.tf

modules/simple_workflow/outputs.tf

modules/simple_workflow/variables.tf

test/fixtures/simple_workflow/main.tf

modules/simple_workflow/metadata.yaml

modules/simple_workflow/variables.tf

examples/simple_workflow/main.tf

anaik91

lgtm

bharathkkb · 2025-11-03T16:03:58Z

examples/simple_workflow/versions.tf

+ * limitations under the License.
+ */
+
+terraform {


We can omit this for examples

bharathkkb · 2025-11-03T16:06:33Z

examples/simple_workflow/outputs.tf

+output "project_id" {
+  description = "Google Cloud project in which the workflow is deployed"
+  value       = var.project_id
+}


If this is for use in test, lets use GetTFSetupStringOutput("project_id") to retrieve it rather than redirecting inputs as outputs

If this is for use in test, lets use GetTFSetupStringOutput("project_id") to retrieve it rather than redirecting inputs as outputs

updated to use GetTFSetupStringOutput

anshukaira · 2025-11-04T19:10:26Z

/gcbrun

anshukaira · 2025-11-04T19:45:22Z

/gcbrun

anshukaira requested review from a team and anaik91 as code owners October 16, 2025 07:31

anshukaira force-pushed the simple-workflow branch from a5a507c to 9180d2a Compare October 17, 2025 04:56

anshukaira changed the title ~~chore : Adding Sub-module for Standalone Workflow for ADC~~ chore: Adding Sub-module for Standalone Workflow for ADC Oct 17, 2025

anshukaira changed the title ~~chore: Adding Sub-module for Standalone Workflow for ADC~~ chore: Adding Submodule for Standalone Workflow for ADC Oct 17, 2025

anshukaira force-pushed the simple-workflow branch 3 times, most recently from a56480a to 3b177bf Compare October 17, 2025 05:29

chore: Adding Submodule for Standalone Workflow for ADC

aecc2c0

- Added Submodule for Standalone workflow - Added Validations and metadata.display.yaml file for making submodule ADC compliant - Added relevant examples and test

anshukaira force-pushed the simple-workflow branch from 3b177bf to aecc2c0 Compare October 17, 2025 06:42

krprabhat-eng reviewed Oct 22, 2025

View reviewed changes

q2w reviewed Oct 22, 2025

View reviewed changes

modules/simple_workflow/variables.tf Outdated Show resolved Hide resolved

anshukaira force-pushed the simple-workflow branch from 52c745e to fb37486 Compare October 27, 2025 16:20

Removed service account usage in simple-workflow module

0a5caf0

anshukaira force-pushed the simple-workflow branch from fb37486 to 0a5caf0 Compare October 27, 2025 16:29

q2w approved these changes Oct 28, 2025

View reviewed changes

krprabhat-eng reviewed Oct 28, 2025

View reviewed changes

examples/simple_workflow/main.tf Show resolved Hide resolved

krprabhat-eng approved these changes Oct 28, 2025

View reviewed changes

anshukaira force-pushed the simple-workflow branch 2 times, most recently from ceaa610 to e14c5fe Compare October 29, 2025 15:28

anaik91 approved these changes Oct 30, 2025

View reviewed changes

bharathkkb approved these changes Nov 3, 2025

View reviewed changes

bharathkkb changed the title ~~chore: Adding Submodule for Standalone Workflow for ADC~~ feat: Adding Submodule for Standalone Workflow for ADC Nov 3, 2025

anshukaira force-pushed the simple-workflow branch 5 times, most recently from 249f4c3 to 798148c Compare November 4, 2025 18:47

anshukaira force-pushed the simple-workflow branch from 798148c to e8e8f2e Compare November 4, 2025 19:42

Updating google provider version

3970cfc

anshukaira force-pushed the simple-workflow branch 2 times, most recently from 981ee1e to d4e1f27 Compare November 6, 2025 13:20

fix: fixing broken tests

4dfc1ba

anshukaira force-pushed the simple-workflow branch 10 times, most recently from 82cff5a to 07bd36a Compare November 10, 2025 10:15

Adding delay and creating a iam_member for service agent

ee20c52

anshukaira force-pushed the simple-workflow branch from 07bd36a to ee20c52 Compare November 10, 2025 13:55

feat: Adding Submodule for Standalone Workflow for ADC #54

Are you sure you want to change the base?

feat: Adding Submodule for Standalone Workflow for ADC #54

Uh oh!

Conversation

anshukaira commented Oct 16, 2025

Uh oh!

anshukaira commented Oct 16, 2025

Uh oh!

anshukaira commented Oct 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anaik91 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anshukaira commented Nov 4, 2025

Uh oh!

anshukaira commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants